woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

Selecting shipping service header #12840

Closed atorresveiga closed 3 weeks ago

atorresveiga commented 3 weeks ago

Part of: #12285

Description

This PR starts the Shipping rates card work and introduces the shipping rates card header. The header contains the sorting rate selection and the title. For the sorting rate selection, I used the DropdownMenu from Jetpack Compose. For the sorting options, I created the ShippingSortOption enum.

Testing information

  1. Create an Order with the processing status on a store that can create shipping labels
  2. Tap on Orders
  3. Tap on the order created on step 1
  4. Tap con create shipping labels
  5. Check that Shipment details card is displayed at the bottom of the screen
  6. Tap on/Drag up Shipment details
  7. Check that the bottom sheets expand and the shipping rates header is visible

The tests that have been performed

  1. Test that the UI interaction works as expected

Images/gif

https://github.com/user-attachments/assets/12680720-d24c-4c29-abf1-8b08edbdbe40

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

dangermattic commented 3 weeks ago
1 Warning
:warning: Class ShippingSortOption is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 weeks ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit2ca1db0754bf17e32d7d3e84e342989c0f099bde
Direct Downloadwoocommerce-wear-prototype-build-pr12840-2ca1db0.apk
wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit2ca1db0754bf17e32d7d3e84e342989c0f099bde
Direct Downloadwoocommerce-prototype-build-pr12840-2ca1db0.apk
codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 76 lines in your changes missing coverage. Please review.

Project coverage is 40.34%. Comparing base (dbbc138) to head (2ca1db0). Report is 5 commits behind head on trunk.

Files with missing lines Patch % Lines
...i/orders/wooshippinglabels/ShippingRatesSection.kt 0.00% 76 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #12840 +/- ## ============================================ - Coverage 40.38% 40.34% -0.05% Complexity 5773 5773 ============================================ Files 1243 1244 +1 Lines 70716 70792 +76 Branches 9877 9892 +15 ============================================ Hits 28558 28558 - Misses 39526 39602 +76 Partials 2632 2632 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.