woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

Shipping rates pagination with tabs #12851

Closed atorresveiga closed 3 weeks ago

atorresveiga commented 3 weeks ago

Part of: #12285

Description

This PR includes the carrier pager to display the shipping rates in the Shipping Rates card. The changes in this PR only contain the pager interaction and the functions to generate mock data. The connection with real data will be tackled in a different PR.

Testing information

  1. Create an Order with the processing status on a store that can create shipping labels
  2. Tap on Orders
  3. Tap on the order created on step 1
  4. Tap con create shipping labels
  5. Tap on the different carriers and check that the carrier content change
  6. Swipe the carrier content horizontally and check that the selected carrier change

The tests that have been performed

  1. Test that the UI interaction works as expected

Images/gif

https://github.com/user-attachments/assets/bd2d0cb0-80af-4ce5-9368-03314b198d92

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

dangermattic commented 3 weeks ago
2 Warnings
:warning: Class Carrier is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: This PR is assigned to the milestone 21.0. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 weeks ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit46d1a6e7d6ce2274f03faf3afacd89127c162b69
Direct Downloadwoocommerce-wear-prototype-build-pr12851-46d1a6e.apk
wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit46d1a6e7d6ce2274f03faf3afacd89127c162b69
Direct Downloadwoocommerce-prototype-build-pr12851-46d1a6e.apk
codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 110 lines in your changes missing coverage. Please review.

Project coverage is 40.28%. Comparing base (591a59c) to head (46d1a6e). Report is 6 commits behind head on trunk.

Files with missing lines Patch % Lines
...i/orders/wooshippinglabels/ShippingRatesSection.kt 0.00% 110 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #12851 +/- ## ============================================ - Coverage 40.34% 40.28% -0.07% Complexity 5774 5774 ============================================ Files 1246 1246 Lines 70804 70913 +109 Branches 9893 9907 +14 ============================================ Hits 28568 28568 - Misses 39603 39712 +109 Partials 2633 2633 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.