[Order Details] Wrong currency for Shipping Lines

toupper commented 3 weeks ago

Closes: #12849

Description

With this PR we fix the issue where we were showing the store default currency instead of the order one for the shipping lines. This issue surfaced when the order currency was different than the store default one. To fix it we assume that the shipping line amount is in the order currency.

Steps to reproduce

In your store viewfront, create an order with some items with a currency other than the default one. You can do that by accessing the store from a country with a different currency than the default one (better in Incognito mode in the browser). For that to work, you should have enabled the Automatically switch customers to their local currency if it has been enabled in the Multicurrency setting of WooCommerce wp-admin. Ensure that the order has a shipping line.
Open the app and go to orders.
Open the order. Before, the shipping line amount was in the store default currency. Now, it is in the order currency.

Testing information

See steps above.

Screenshots

Before

After

[X] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[X] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[X] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[X] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

dangermattic commented 3 weeks ago

	1 Warning
:warning:	This PR is assigned to the milestone 21.0. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	bc93f104418c1808dc7c8812a80241607474ffe5
	Direct Download	`woocommerce-wear-prototype-build-pr12852-bc93f10.apk`

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	bc93f104418c1808dc7c8812a80241607474ffe5
	Direct Download	`woocommerce-prototype-build-pr12852-bc93f10.apk`

woocommerce / woocommerce-android