woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

[Custom Fields] Fix typo in tracking #12854

Closed hichamboushaba closed 3 weeks ago

hichamboushaba commented 3 weeks ago

Description

While comparing the tracking logic between Android and iOS, I noticed a typo in our implementation (https://github.com/woocommerce/woocommerce-ios/pull/14273#discussion_r1824545874), this PR updates fixes the typo.

Steps to reproduce

Code review and green CI are enough.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

dangermattic commented 3 weeks ago
1 Warning
:warning: This PR is assigned to the milestone 20.9 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 weeks ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit1d57999f643c8bbca102cc6f64c5f32622f5ea02
Direct Downloadwoocommerce-wear-prototype-build-pr12854-1d57999.apk
wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit1d57999f643c8bbca102cc6f64c5f32622f5ea02
Direct Downloadwoocommerce-prototype-build-pr12854-1d57999.apk
codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.86%. Comparing base (58a2bd2) to head (1d57999). Report is 2 commits behind head on release/20.9.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/20.9 #12854 +/- ## =============================================== Coverage 40.86% 40.86% Complexity 5771 5771 =============================================== Files 1237 1237 Lines 69861 69861 Branches 9708 9708 =============================================== Hits 28552 28552 Misses 38677 38677 Partials 2632 2632 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.