[Tooling] Update Dangermattic

woocommerce / woocommerce-android

WooCommerce Android app

https://www.woocommerce.com/mobile

GNU General Public License v2.0

277 stars 135 forks source link

[Tooling] Update Dangermattic #12859

Closed iangmaia closed 2 weeks ago

iangmaia commented 2 weeks ago

This PR updates Dangermattic; the main goal is to update to get a fix to the View Check validation, which reports a warning whenever there are changes to View files and the PR doesn't have screenshots / videos attached. There was a bug where it would wrongly report a warning even with a video/image already in the description. (example)

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	72410ace082d636907df13f11f89ec976bd5ef6d
	Direct Download	`woocommerce-wear-prototype-build-pr12859-72410ac.apk`

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	72410ace082d636907df13f11f89ec976bd5ef6d
	Direct Download	`woocommerce-prototype-build-pr12859-72410ac.apk`

AliSoftware commented 2 weeks ago

Opened https://github.com/woocommerce/woocommerce-android/pull/12866 to test the fix, now waiting for CI to run and detect a false negative with old Dangermattic version—after which I plan to rebase on top of this PR then run Dangermattic again and confirm the false negative disappears with the Dangermattic update…

dangermattic commented 2 weeks ago

	1 Warning
:warning:	This PR is assigned to the milestone 21.1. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

iangmaia commented 2 weeks ago

@AliSoftware did you have the chance to verify it after all? 🙂

AliSoftware commented 2 weeks ago

@AliSoftware did you have the chance to verify it after all? 🙂

@iangmaia as mentioned in https://github.com/woocommerce/woocommerce-android/pull/12866#issuecomment-2454920224 I want able to reproduce the false positive to begin with first, so no 😞 If you hand any idea why I can't repro, I've pinged you in https://github.com/woocommerce/woocommerce-android/pull/12866

iangmaia commented 2 weeks ago

@AliSoftware did you have the chance to verify it after all? 🙂

@iangmaia as mentioned in #12866 (comment) I want able to reproduce the false positive to begin with first, so no 😞 If you hand any idea why I can't repro, I've pinged you in #12866

Ah, my bad. I read that comment but was in the middle of something else and forgot to follow up. Will look into it now.