woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

Shipping rates: rate selection #12863

Closed atorresveiga closed 2 weeks ago

atorresveiga commented 2 weeks ago

Closes: #12285

Description

This PR adds shipping rates items UI. With the changes included here, it is now possible to select (expand) shipping rates and select/unselect the signature-required options. This PR also updates the RoundedCornerBoxWithBorder composable, allowing it to receive border and background parameters. This PR focuses only on UI; the components here will be connected with real data in a different PR.

Testing information

  1. Create an Order with the processing status on a store that can create shipping labels
  2. Tap on Orders
  3. Tap on the order created on step 1
  4. Tap con create shipping labels
  5. Check that the shipping service card is visible
  6. Tap on different carriers and check that the card information changes
  7. Tap on a shipping rate and check that when selected, the shipping rate information expands
  8. Tap on a signature required option and check that it selects
  9. Tap on the selected option for the required signature and ensure that it deselects.

The tests that have been performed

  1. Test that the UI interaction works as expected

Images/gif

https://github.com/user-attachments/assets/355e7dd1-0fe3-4e65-b337-e3731911dd9a

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

dangermattic commented 2 weeks ago
2 Warnings
:warning: This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
:warning: Class SignatureRequired is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by :no_entry_sign: Danger

wpmobilebot commented 2 weeks ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitf9e8267f1f4e210bd3af68a215aa48bfa393c538
Direct Downloadwoocommerce-wear-prototype-build-pr12863-f9e8267.apk
wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitf9e8267f1f4e210bd3af68a215aa48bfa393c538
Direct Downloadwoocommerce-prototype-build-pr12863-f9e8267.apk
codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 213 lines in your changes missing coverage. Please review.

Project coverage is 40.18%. Comparing base (d0fe8ce) to head (f9e8267). Report is 6 commits behind head on trunk.

Files with missing lines Patch % Lines
...i/orders/wooshippinglabels/ShippingRatesSection.kt 0.00% 206 Missing :warning:
...rders/wooshippinglabels/WooShippingProductsCard.kt 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #12863 +/- ## ============================================ - Coverage 40.28% 40.18% -0.11% Complexity 5774 5774 ============================================ Files 1246 1246 Lines 70913 71091 +178 Branches 9907 9935 +28 ============================================ Hits 28568 28568 - Misses 39712 39890 +178 Partials 2633 2633 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.