woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

Shipping Lines in Order Creation are editable at all times #12869

Closed malinajirka closed 2 weeks ago

malinajirka commented 2 weeks ago

Describe the bug The shipping lines in the order creation/order edit flows, are editable at all times. For example, when the order is being refreshed, I'm able to edit the shipping lines even though all the other features on the other are disabled. I'm also able to edit shipping lines when I enter the edit mode on a paid order.

To Reproduce Steps to reproduce the behavior:

  1. Go to Order List
  2. Click on Create Order
  3. Add a product
  4. Notice Add shipping button is disabled when the order is refreshed (this is expected behavior)
  5. Add a shipping line
  6. 🐛 Notice the added shipping line is editable when the order is refreshed
  7. Add a product
  8. 🐛 Notice Add shipping button is enabled when the order is refreshed (this is not expected)

Steps to reproduce the behavior:

  1. Open detail of a paid order with a shipping line
  2. Tap on Edit
  3. Notice you can edit shipping lines even though the order is not editable

Expected behavior Shipping line should be disabled when editing paid orders or when the order is being updated in the background in the order creation. The behavior should be consistent with Coupons when this PR is merged.

Isolating the problem (mark completed items with an [x]):

dangermattic commented 2 weeks ago

Thanks for reporting! 👍