woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

[Fix] Receipt is not attached to text message #12874

Closed kidinov closed 2 weeks ago

kidinov commented 2 weeks ago

Closes: #12793

Description

The SMS app (the one from google) doesn't want to attach to messages files with generic mime type. This PR changes mime type we use to share receipts to fix that

Steps to reproduce

Testing information

The tests that have been performed

The one from Steps to Reproduce and

Images/gif

https://github.com/user-attachments/assets/adf75611-4198-4de6-9ccf-8d9c2546fa4c

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

wpmobilebot commented 2 weeks ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitd56cae46d9cd558ab87154b59b24b5d978bd8e42
Direct Downloadwoocommerce-wear-prototype-build-pr12874-d56cae4.apk
wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitd56cae46d9cd558ab87154b59b24b5d978bd8e42
Direct Downloadwoocommerce-prototype-build-pr12874-d56cae4.apk
codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.24%. Comparing base (995e65a) to head (d56cae4). Report is 25 commits behind head on trunk.

Files with missing lines Patch % Lines
...android/ui/payments/receipt/PaymentReceiptShare.kt 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #12874 +/- ## ========================================= Coverage 40.24% 40.24% Complexity 5784 5784 ========================================= Files 1247 1247 Lines 71160 71160 Branches 9933 9933 ========================================= Hits 28638 28638 Misses 39889 39889 Partials 2633 2633 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dangermattic commented 2 weeks ago
1 Warning
:warning: This PR is assigned to the milestone 21.1. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger