[Fix] Open web views in 3/4 in the PaymentsHubFragment

kidinov commented 2 weeks ago

Closes: #12625

Description

The PR makes all the web views to be open in 3/4 of the screen on, to make it consistent

Steps to reproduce

More -> Payments -> Learn more

Testing information

The tests that have been performed

Only STR

Images/gif

https://github.com/user-attachments/assets/d5b1d05a-5552-4a96-a80f-0165aac92957

[x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[x] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[x] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[x] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

625

dangermattic commented 2 weeks ago

	1 Warning
:warning:	This PR is assigned to the milestone 21.1. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	7bfaf90ba177fd92f7794b5714a1bb2cf9d7d2ed
	Direct Download	`woocommerce-wear-prototype-build-pr12875-7bfaf90.apk`

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	7bfaf90ba177fd92f7794b5714a1bb2cf9d7d2ed
	Direct Download	`woocommerce-prototype-build-pr12875-7bfaf90.apk`

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.25%. Comparing base (55a383d) to head (7bfaf90). Report is 4 commits behind head on trunk.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #12875 +/- ## ========================================= Coverage 40.25% 40.25% Complexity 5786 5786 ========================================= Files 1249 1249 Lines 71174 71174 Branches 9934 9934 ========================================= Hits 28651 28651 Misses 39889 39889 Partials 2634 2634 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kidinov commented 2 weeks ago

@AnirudhBhat

This shouldn't be a problem. IMO, most of the Android users are familiar that they can swipe the view up (web view) if they want to read further. WDYT?

I think this is fine

Could you also go through the check list on the PR description?

woocommerce / woocommerce-android