Lock shipping lines - Githubissues

atorresveiga commented 2 weeks ago

Closes: #12869

Description

This PR fixes the issue of the shipping lines being editable at all times. It does that by introducing the ShippingLineSection class that includes the isEnabled state. Relying on the isEnabled state value, the shipping lines section now locks(disabled) the interaction with the shipping lines controls if the isEnabled property is false,

Testing information

Go to Order List
Click on Create Order
Add a product
Notice Add shipping button is disabled when the order is refreshed
Add a shipping line
Notice the added shipping line is disabled when the order is refreshed
Add a product
Notice Add shipping button is disabled when the order is refreshed

The tests that have been performed

Testing that the shipping lines section is disabled when the order is refreshing or is not editable.

Images/gif

https://github.com/user-attachments/assets/5c87bad7-0993-44e5-a9cf-4539bd198466

[x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[x] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[x] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[x] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

dangermattic commented 2 weeks ago

	1 Warning
:warning:	This PR is assigned to the milestone 21.1. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	b9516d90f87b5128114224e8cb79996d70f9b77b
	Direct Download	`woocommerce-wear-prototype-build-pr12890-b9516d9.apk`

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	b9516d90f87b5128114224e8cb79996d70f9b77b
	Direct Download	`woocommerce-prototype-build-pr12890-b9516d9.apk`

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 17.74194% with 51 lines in your changes missing coverage. Please review.

Project coverage is 40.20%. Comparing base (28229e5) to head (b9516d9). Report is 11 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...rders/creation/shipping/ShippingLineFormSection.kt	0.00%	49 Missing :warning:
...oid/ui/orders/creation/OrderCreateEditViewModel.kt	80.00%	0 Missing and 2 partials :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #12890 +/- ## ============================================ - Coverage 40.22% 40.20% -0.02% - Complexity 5790 5791 +1 ============================================ Files 1252 1253 +1 Lines 71329 71359 +30 Branches 9958 9963 +5 ============================================ + Hits 28690 28693 +3 - Misses 40005 40030 +25 - Partials 2634 2636 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

woocommerce / woocommerce-android

Lock shipping lines #12890