woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

[Crash] Revert "Lock shipping lines" PR #12892

Closed kidinov closed 1 week ago

kidinov commented 1 week ago

Reverts woocommerce/woocommerce-android#12890

The PR causes a crash when a user attempts to edit an order

FATAL EXCEPTION: main
                                                                                                    Process: com.woocommerce.android.dev, PID: 16548
                                                                                                    java.lang.IllegalStateException: Multiple observers registered but only one is supported.
                                                                                                        at com.woocommerce.android.viewmodel.LiveDataDelegate.observe(LiveDataDelegate.kt:53)
                                                                                                        at com.woocommerce.android.ui.orders.creation.OrderCreateEditFormFragment.observeViewStateChanges(OrderCreateEditFormFragment.kt:484)
                                                                                                        at com.woocommerce.android.ui.orders.creation.OrderCreateEditFormFragment.setupObserversWith(OrderCreateEditFormFragment.kt:416)
                                                                                                        at com.woocommerce.android.ui.orders.creation.OrderCreateEditFormFragment.onViewCreated(OrderCreateEditFormFragment.kt:164)
                                                                                                        at androidx.fragment.app.Fragment.performViewCreated(Fragment.java:3152)
                                                                                                        at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:608)
                                                                                                        at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:286)
                                                                                                        at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2164)
                                                                                                        at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2065)
                                                                                                        at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:2002)
                                                                                                        at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:702)
                                                                                                        at android.os.Handler.handleCallback(Handler.java:938)
                                                                                                        at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                                        at android.os.Looper.loopOnce(Looper.java:201)
                                                                                                        at android.os.Looper.loop(Looper.java:288)
                                                                                                        at android.app.ActivityThread.main(ActivityThread.java:7839)
                                                                                                        at java.lang.reflect.Method.invoke(Native Method)
                                                                                                        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                                                                                                        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
dangermattic commented 1 week ago
1 Warning
:warning: This PR is assigned to the milestone 21.1. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 week ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitb8ee086f618f97211277a43578a0d2afc32d2290
Direct Downloadwoocommerce-wear-prototype-build-pr12892-b8ee086.apk
wpmobilebot commented 1 week ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitb8ee086f618f97211277a43578a0d2afc32d2290
Direct Downloadwoocommerce-prototype-build-pr12892-b8ee086.apk
codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 21.87500% with 25 lines in your changes missing coverage. Please review.

Project coverage is 40.21%. Comparing base (412ef4e) to head (b8ee086). Report is 3 commits behind head on trunk.

Files with missing lines Patch % Lines
...rders/creation/shipping/ShippingLineFormSection.kt 0.00% 24 Missing :warning:
...oid/ui/orders/creation/OrderCreateEditViewModel.kt 87.50% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #12892 +/- ## ========================================= Coverage 40.20% 40.21% + Complexity 5795 5793 -2 ========================================= Files 1256 1255 -1 Lines 71427 71397 -30 Branches 9973 9968 -5 ========================================= - Hits 28717 28711 -6 + Misses 40071 40048 -23 + Partials 2639 2638 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.