woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

[Woo POS payments onboarding] Show payments IPP onboarding #12895

Closed kidinov closed 3 days ago

kidinov commented 1 week ago

Closes: #12882

Description

The PR:

Steps to reproduce

Try different cases available to you of the IPP onboarding not finished

The tests that have been performed

I tested:

Images/gif

https://github.com/user-attachments/assets/e265de7c-2445-49f1-9c8a-1a2c3b6faa17

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

wpmobilebot commented 1 week ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit9ec14d1b48995fff68344c2b7d878ea8f25f6183
Direct Downloadwoocommerce-wear-prototype-build-pr12895-9ec14d1.apk
wpmobilebot commented 1 week ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit9ec14d1b48995fff68344c2b7d878ea8f25f6183
Direct Downloadwoocommerce-prototype-build-pr12895-9ec14d1.apk
codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 40.22%. Comparing base (6dbb6de) to head (9ec14d1). Report is 283 commits behind head on trunk.

Files with missing lines Patch % Lines
...oid/ui/woopos/cardreader/WooPosCardReaderFacade.kt 0.00% 8 Missing :warning:
...ndroid/ui/woopos/util/ext/WindowInsetsCompatExt.kt 0.00% 7 Missing :warning:
...reader/onboarding/CardReaderOnboardingViewModel.kt 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #12895 +/- ## ============================================ - Coverage 40.22% 40.22% -0.01% Complexity 5794 5794 ============================================ Files 1252 1253 +1 Lines 71266 71273 +7 Branches 9956 9957 +1 ============================================ Hits 28669 28669 - Misses 39968 39975 +7 Partials 2629 2629 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dangermattic commented 1 week ago
1 Warning
:warning: This PR is assigned to the milestone 21.2. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger