woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

[Deps] Update Kotlin to 2.0.21 #12896

Closed ParaskP7 closed 1 week ago

ParaskP7 commented 1 week ago

Project Thread: paaHJt-7n2-p2 Associated Metrics: paaHJt-7n2-p2#comment-9682

This PR updates Kotlin to 2.0 (2.0.21).

Description

FYI: I recommend reviewing this PR commit-by-commit just to make sure that Kotlin has been updated appropriately and that there isn't any left-overs that need addressing.

PS: Main commits for some extra focus:

Testing information

(*) Unfortunately, this comment exceeds 65400 characters and thus the only way for us to check on the diff is to do it via the CI artifacts. You could focus on:

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

wpmobilebot commented 1 week ago

Build environment changes

Content exceeds 65400 characters. Navigate to Buildkite build artifacts to see details.

wpmobilebot commented 1 week ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit35ddc4aaf3cd3b66df461909109b124670f7ad15
Direct Downloadwoocommerce-wear-prototype-build-pr12896-35ddc4a.apk
wpmobilebot commented 1 week ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit35ddc4aaf3cd3b66df461909109b124670f7ad15
Direct Downloadwoocommerce-prototype-build-pr12896-35ddc4a.apk
codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.61%. Comparing base (3444338) to head (a65218c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #12896 +/- ## ============================================ - Coverage 40.17% 39.61% -0.57% - Complexity 5798 5918 +120 ============================================ Files 1258 1258 Lines 71547 72739 +1192 Branches 9979 9950 -29 ============================================ + Hits 28747 28813 +66 - Misses 40161 41362 +1201 + Partials 2639 2564 -75 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ParaskP7 commented 1 week ago

👋 @wzieba !

Is there any place to review build performance changes for this update?

Don't you mean this: Associated Metrics: paaHJt-7n2-p2#comment-9682 (see PR description, on top) 🤔

Or, do you have something else in mind? 🤔

wzieba commented 1 week ago

Don't you mean this: Associated Metrics: paaHJt-7n2-p2#comment-9682 (see PR description, on top) 🤔

Yes, thanks!

ParaskP7 commented 1 week ago

👋 @samiuelson !

You being part of the product team, are you able to code review/test this Kotlin 2.0 change before us merging this to trunk. In addition to the 👍 from Wojtek, I would love if someone from the product team gives the final 👍 . Else, let me know if you're not available. I will then re-assign this to someone with more bandwidth. 🙏

ParaskP7 commented 1 week ago

Awesome @samiuelson , thanks for reviewing, testing and giving your final 👍 on this change, I update this PR with the latest changed from trunk, will wait on CI to go 🟢 and then merge this! 🙇 ❤️ 🚀