Closed ParaskP7 closed 1 week ago
Content exceeds 65400 characters. Navigate to Buildkite build artifacts to see details.
App Name | WooCommerce-Wear Android | |
Platform | ⌚️ Wear OS | |
Flavor | Jalapeno | |
Build Type | Debug | |
Commit | 35ddc4aaf3cd3b66df461909109b124670f7ad15 | |
Direct Download | woocommerce-wear-prototype-build-pr12896-35ddc4a.apk |
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
App Name | WooCommerce Android | |
Platform | 📱 Mobile | |
Flavor | Jalapeno | |
Build Type | Debug | |
Commit | 35ddc4aaf3cd3b66df461909109b124670f7ad15 | |
Direct Download | woocommerce-prototype-build-pr12896-35ddc4a.apk |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 39.61%. Comparing base (
3444338
) to head (a65218c
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
👋 @wzieba !
Is there any place to review build performance changes for this update?
Don't you mean this: Associated Metrics: paaHJt-7n2-p2#comment-9682 (see PR description, on top) 🤔
Or, do you have something else in mind? 🤔
Don't you mean this: Associated Metrics: paaHJt-7n2-p2#comment-9682 (see PR description, on top) 🤔
Yes, thanks!
👋 @samiuelson !
You being part of the product team, are you able to code review/test this Kotlin 2.0 change before us merging this to trunk
. In addition to the 👍 from Wojtek, I would love if someone from the product team gives the final 👍 . Else, let me know if you're not available. I will then re-assign this to someone with more bandwidth. 🙏
Awesome @samiuelson , thanks for reviewing, testing and giving your final 👍 on this change, I update this PR with the latest changed from trunk
, will wait on CI to go 🟢 and then merge this! 🙇 ❤️ 🚀
Project Thread: paaHJt-7n2-p2 Associated Metrics: paaHJt-7n2-p2#comment-9682
This PR updates Kotlin to 2.0 (2.0.21).
Description
FYI: I recommend reviewing this PR commit-by-commit just to make sure that Kotlin has been updated appropriately and that there isn't any left-overs that need addressing.
PS: Main commits for some extra focus:
Testing information
./gradlew buildHealth
task locally and verify that everything is working as expected (CI).(*) Unfortunately, this comment exceeds 65400 characters and thus the only way for us to check on the diff is to do it via the CI artifacts. You could focus on:
tldr_diff_dependencies.txt
tldr_diff_build_env.txt
[x] I have considered if this change warrants release notes and have added them to
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: