woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

Fix ScreenshotTest #12906

Closed irfano closed 1 week ago

irfano commented 1 week ago

Closes: #https://github.com/woocommerce/woomobile-private/issues/393

Description

This fixes failing ScreenshotTest and related script in Fastfile.

Steps to reproduce

  1. Run ScreenshotTest.
  2. Run bundle exec fastlane take_screenshotslocales:en-US.

Testing information

ScreenshotTest

The test should pass.

bundle exec fastlane take_screenshotslocales:en-US

This command should generate screenshots in /fastlane/screenshots/raw/en-US/images/phoneScreenshots

The tests that have been performed

Generated raw screenhots. image

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

wpmobilebot commented 1 week ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitde64bb3b957c9542b0b918ccdc8c86fca1cd8b96
Direct Downloadwoocommerce-wear-prototype-build-pr12906-de64bb3.apk
wpmobilebot commented 1 week ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitde64bb3b957c9542b0b918ccdc8c86fca1cd8b96
Direct Downloadwoocommerce-prototype-build-pr12906-de64bb3.apk
JorgeMucientes commented 1 week ago

Great job fixing this @irfano! Works well. I could run the Screenshots class successfully. However, as discussed over DM I was not able to run bundle exec fastlane take_screenshotslocales:en-US due to my local setup. Since the main changes belong to the Screenshots class and related, not being able to run the fastlane command shouldn't be an issue. Let's :shipit: