Closed irfano closed 1 week ago
App Name | WooCommerce-Wear Android | |
Platform | ⌚️ Wear OS | |
Flavor | Jalapeno | |
Build Type | Debug | |
Commit | de64bb3b957c9542b0b918ccdc8c86fca1cd8b96 | |
Direct Download | woocommerce-wear-prototype-build-pr12906-de64bb3.apk |
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
App Name | WooCommerce Android | |
Platform | 📱 Mobile | |
Flavor | Jalapeno | |
Build Type | Debug | |
Commit | de64bb3b957c9542b0b918ccdc8c86fca1cd8b96 | |
Direct Download | woocommerce-prototype-build-pr12906-de64bb3.apk |
Great job fixing this @irfano! Works well. I could run the Screenshots
class successfully. However, as discussed over DM I was not able to run bundle exec fastlane take_screenshotslocales:en-US
due to my local setup. Since the main changes belong to the Screenshots
class and related, not being able to run the fastlane command shouldn't be an issue.
Let's :shipit:
Closes: #https://github.com/woocommerce/woomobile-private/issues/393
Description
This fixes failing
ScreenshotTest
and related script inFastfile
.Steps to reproduce
ScreenshotTest
.bundle exec fastlane take_screenshotslocales:en-US
.Testing information
ScreenshotTest
The test should pass.
bundle exec fastlane take_screenshotslocales:en-US
This command should generate screenshots in
/fastlane/screenshots/raw/en-US/images/phoneScreenshots
The tests that have been performed
Generated raw screenhots.
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: