woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

[Woo POS payments onboarding] Handle case when we dont know country and currency #12908

Closed kidinov closed 3 days ago

kidinov commented 1 week ago

Closes: #12904

Description

The PR:

Steps to reproduce

The tests that have been performed

Images/gif

https://github.com/user-attachments/assets/ab07ff67-c52c-4b17-ac9b-9f2446a970ca

https://github.com/user-attachments/assets/bcf521f3-45ba-412f-9492-462ecaa98781

https://github.com/user-attachments/assets/1413c3ef-82f3-49bf-a50d-ecc6220a2e01

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

wpmobilebot commented 1 week ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit3e60a27d206e71410f1bbdcbe13f42b616b2f7aa
Direct Downloadwoocommerce-wear-prototype-build-pr12908-3e60a27.apk
wpmobilebot commented 1 week ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit3e60a27d206e71410f1bbdcbe13f42b616b2f7aa
Direct Downloadwoocommerce-prototype-build-pr12908-3e60a27.apk
codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 40.21%. Comparing base (9ec14d1) to head (ad138a9).

Files with missing lines Patch % Lines
...m/woocommerce/android/ui/woopos/WooPosIsEnabled.kt 71.42% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 12882-woo-pos---payments-onboarding-show-payments-onboarding-from-existing-design #12908 +/- ## ======================================================================================================================= - Coverage 40.22% 40.21% -0.01% + Complexity 5794 5793 -1 ======================================================================================================================= Files 1253 1253 Lines 71273 71268 -5 Branches 9957 9956 -1 ======================================================================================================================= - Hits 28669 28663 -6 Misses 39975 39975 - Partials 2629 2630 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.