Closed AnirudhBhat closed 22 hours ago
4 Warnings | |
---|---|
:warning: | This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews. |
:warning: | Class WooPosBaseViewState is missing tests, but unit-tests-exemption label was set to ignore this. |
:warning: | Class WooPosVariationEvents is missing tests, but unit-tests-exemption label was set to ignore this. |
:warning: | This PR is assigned to the milestone 21.2. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline. |
Generated by :no_entry_sign: Danger
App Name | WooCommerce-Wear Android | |
Platform | ⌚️ Wear OS | |
Flavor | Jalapeno | |
Build Type | Debug | |
Commit | 4e26906a25bb758c236c6d4896526cd4e6afecec | |
Direct Download | woocommerce-wear-prototype-build-pr12910-4e26906.apk |
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
App Name | WooCommerce Android | |
Platform | 📱 Mobile | |
Flavor | Jalapeno | |
Build Type | Debug | |
Commit | 4e26906a25bb758c236c6d4896526cd4e6afecec | |
Direct Download | woocommerce-prototype-build-pr12910-4e26906.apk |
Attention: Patch coverage is 32.02417%
with 225 lines
in your changes missing coverage. Please review.
Project coverage is 39.59%. Comparing base (
fb44b49
) to head (4e26906
). Report is 210 commits behind head on trunk.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Closes: #12844
NOTE: I've extracted the UI in the products screen into separate file which is the cause for many line changes.
Description
This PR fetches variations list and displays on the variations screen.
It makes use of existing
VariationsListHandler
class for fetching variations.Testing information
Testing Variations list
Testing Variations pagination
Testing Variations pagination error
Testing Variations fetch error
The tests that have been performed
Tested all the above scenario listed in both light and dark modes on emulator.
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: