Fix crash for mismatched account case

irfano commented 1 week ago

(cherry picked from commit 8219ffa0b7d5a58daf2d81bc9ed201d6f7a39561)

Description

This fixes a crash on the site picker screen when the sites data is null. I couldn't reproduce the crash. But when the sites.value is null for any reason, it makes sense to hide the primary button on the site picker screen. This case may occur rarely and temporarily when the screen is initializing.

Steps to reproduce

"To reproduce the issue, you need a WordPress.com account with 0 sites. Not even a blog. Which is tricky to get through the normal flow because WP.com will create 1 blog for you as soon as you create a new account. However, if you delete that blog (and wait a few hours until the deletion is completed) you'll end up with a WP.com account with 0 sites. Using that account o log into any Jetpack connected site will result in the account mismatch screen and the app crashing. - https://github.com/woocommerce/woocommerce-android/pull/12889#issuecomment-2462908860"

Testing information

Tested normal mismatch account case.

The tests that have been performed

Tested normal mismatch account case again for this PR.

[x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[x] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[x] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[x] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

dangermattic commented 1 week ago

	1 Warning
:warning:	This PR is assigned to the milestone 21.0.1. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 week ago

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	cab947359dad907129d0d8c909109a8735c734f3
	Direct Download	`woocommerce-wear-prototype-build-pr12914-cab9473.apk`

wpmobilebot commented 1 week ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	cab947359dad907129d0d8c909109a8735c734f3
	Direct Download	`woocommerce-prototype-build-pr12914-cab9473.apk`

woocommerce / woocommerce-android