woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

[Woo POS payments onboarding] Analytics events #12922

Closed kidinov closed 2 days ago

kidinov commented 1 week ago

Closes: #12903

Description

The PR adds:

Steps to reproduce

Notice the events:

🔵 Tracked: woocommerceandroid_pos_payments_onboarding_shown, Properties: {"onboarding_state":"account_overdue_requirements","plugin_slug":"woocommerce-payments","country":"US","blog_id":198219640,"is_wpcom_store":true,"was_ecommerce_trial":false,"plan_product_slug":"business-bundle","store_id":"f7681b0f-a272-4402-9520-0b1471736552","is_debug":true,"site_url":"https:\/\/anotherpaymentssite.wpcomstaging.com","cached_woo_core_version":"9.4.1"}
🔵 Tracked: woocommerceandroid_hub_menu_option_tapped, Properties: {"option":"pointOfSale","blog_id":198219640,"is_wpcom_store":true,"was_ecommerce_trial":false,"plan_product_slug":"business-bundle","store_id":"f7681b0f-a272-4402-9520-0b1471736552","is_debug":true,"site_url":"https:\/\/anotherpaymentssite.wpcomstaging.com","cached_woo_core_version":"9.4.1"}
🔵 Tracked: woocommerceandroid_blaze_entry_point_displayed, Properties: {"source":"menu","blog_id":198219640,"is_wpcom_store":true,"was_ecommerce_trial":false,"plan_product_slug":"business-bundle","store_id":"f7681b0f-a272-4402-9520-0b1471736552","is_debug":true,"site_url":"https:\/\/anotherpaymentssite.wpcomstaging.com","cached_woo_core_version":"9.4.1"}

Testing information

Follow steps to reproduce

The tests that have been performed

From steps to reproduce

Images/gif

No UI changes in the PR expected

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

dangermattic commented 1 week ago
1 Message
:book:

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 week ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit5007efb951f46361f7efa7d3a20d6e936d4dfd01
Direct Downloadwoocommerce-wear-prototype-build-pr12922-5007efb.apk
wpmobilebot commented 1 week ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit5007efb951f46361f7efa7d3a20d6e936d4dfd01
Direct Downloadwoocommerce-prototype-build-pr12922-5007efb.apk
codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 39.64%. Comparing base (3e60a27) to head (5007efb). Report is 44 commits behind head on trunk.

Files with missing lines Patch % Lines
...reader/onboarding/CardReaderOnboardingViewModel.kt 60.00% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #12922 +/- ## ============================================ + Coverage 39.61% 39.64% +0.02% - Complexity 5925 5935 +10 ============================================ Files 1261 1261 Lines 72843 72867 +24 Branches 9963 9967 +4 ============================================ + Hits 28855 28885 +30 + Misses 41415 41408 -7 - Partials 2573 2574 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

kidinov commented 2 days ago

@AnirudhBhat thanks for the review

Yep, that's kinda expected as we track the status every time we check it