woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

[Shipping Labels Revamp] Add Improvements and bug fixes to Packages UI #12936

Closed ThomazFB closed 6 days ago

ThomazFB commented 6 days ago

Summary

Add some adjustments to the Package UI selection:

How to Test

  1. As the Package selection system is not yet integrated with real endpoints, it's not possible to effectively test the features introduced here. The unit tests are the only way to verify the behaviors here, which is why this work is still behind a feature flag.

Update release notes:

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

wpmobilebot commented 6 days ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit5bdaf8b6c2f38c25828415b3453851aaa10a0b0a
Direct Downloadwoocommerce-wear-prototype-build-pr12936-5bdaf8b.apk
wpmobilebot commented 6 days ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit5bdaf8b6c2f38c25828415b3453851aaa10a0b0a
Direct Downloadwoocommerce-prototype-build-pr12936-5bdaf8b.apk
codecov-commenter commented 6 days ago

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 39.62%. Comparing base (66014e5) to head (5bdaf8b). Report is 17 commits behind head on trunk.

Files with missing lines Patch % Lines
...ckages/WooShippingLabelPackageCreationViewModel.kt 73.33% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #12936 +/- ## ============================================ + Coverage 39.61% 39.62% +0.01% - Complexity 5927 5928 +1 ============================================ Files 1260 1260 Lines 72832 72841 +9 Branches 9963 9963 ============================================ + Hits 28852 28863 +11 + Misses 41410 41408 -2 Partials 2570 2570 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.