Purchase button adjustments

atorresveiga commented 4 days ago

Part of: #12281

Description

This PR includes the purchase button below the shipment details bottom sheet and improves the landscape support for the main shipping label screen by including the mark order complete control. The changes on this PR are only focused on the UI. Additionally, it updates the mark order complete caption as recommended by design.

The UI adjustments were discussed here: p1732055886685969-slack-C02KUCFCSFP

Testing information

Create an Order with the processing status on a store that can create shipping labels
Tap on Orders
Tap on the order created on step 1
Tap con create shipping labels
Chek that the purchase button is displayed on the main screen
check that the purchase button is displayed after expanding the shipment details section
Change the phone configuration to landscape
Check that on the landscape, the mark order complete switch is displayed
Check that expanding/collapsing the shipment details section works as expected on landscape.

The tests that have been performed

Checking the UI is displayed as expected

Images/gif

https://github.com/user-attachments/assets/7a02c070-040f-4c43-a47d-417981f66199

[x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[x] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[x] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[x] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

dangermattic commented 4 days ago

	1 Warning
:warning:	This PR is assigned to the milestone 21.2. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

wpmobilebot commented 4 days ago

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	0c2943a729dc96741693cf4c19ba8d3fbd398a15
	Direct Download	`woocommerce-wear-prototype-build-pr12939-0c2943a.apk`

wpmobilebot commented 4 days ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	0c2943a729dc96741693cf4c19ba8d3fbd398a15
	Direct Download	`woocommerce-prototype-build-pr12939-0c2943a.apk`

codecov-commenter commented 21 hours ago

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 39.77%. Comparing base (5b945a1) to head (0c2943a). Report is 10 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...oid/ui/orders/wooshippinglabels/ShipmentDetails.kt	0.00%	17 Missing :warning:
...oid/ui/orders/wooshippinglabels/PurchaseSection.kt	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #12939 +/- ## ========================================= Coverage 39.76% 39.77% Complexity 5961 5961 ========================================= Files 1262 1262 Lines 72942 72935 -7 Branches 9976 9978 +2 ========================================= Hits 29009 29009 + Misses 41356 41349 -7 Partials 2577 2577 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

woocommerce / woocommerce-android