[Woo POS - payments onboarding] Remove local FF

kidinov commented 5 days ago

Closes: #12928

Description

The PR removes feature flag

Testing information

Use both release and debug builds
Use site with unfinished onboarding
More -> Payments
Notice that POS is available for both builds
Notice that onboarding is shown on the both builds

The tests that have been performed

Above

Images/gif

https://github.com/user-attachments/assets/650dbb71-0b27-4356-9649-f8c8edc8cb49

[x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[x] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[x] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[x] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

dangermattic commented 5 days ago

	1 Warning
:warning:	This PR is assigned to the milestone 21.2. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

wpmobilebot commented 5 days ago

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	503f98d6f6e958065874290106052300a941f364
	Direct Download	`woocommerce-wear-prototype-build-pr12942-503f98d.apk`

wpmobilebot commented 5 days ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	503f98d6f6e958065874290106052300a941f364
	Direct Download	`woocommerce-prototype-build-pr12942-503f98d.apk`

codecov-commenter commented 2 days ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.73%. Comparing base (81b12c9) to head (503f98d). Report is 12 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...m/woocommerce/android/ui/woopos/WooPosIsEnabled.kt	0.00%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #12942 +/- ## ============================================ - Coverage 39.73% 39.73% -0.01% + Complexity 5985 5983 -2 ============================================ Files 1268 1267 -1 Lines 73252 73222 -30 Branches 10061 10041 -20 ============================================ - Hits 29106 29094 -12 + Misses 41564 41562 -2 + Partials 2582 2566 -16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

woocommerce / woocommerce-android