[POS] Custom payment UI — Part 5 | Unit tests clean up

[samiuelson]

https://github.com/woocommerce/woocommerce-android/pull/12943

Description

This is part 5 of 5 PRs refactoring the Payment flow:

1. [POS] Custom payment UI — Part 1 | Separating payment collection management from Android Framework
2. [POS] Custom payment UI — Part 2 | Separating CardReaderPaymentController's events from MultiLiveEvent
3. [POS] Custom Payment UI – Part 3 | Emitting UI–agnostic payment states in CardReaderPaymentController
4. [POS] Custom payment UI — Part 4 | Switch from viewStateData to paymentState
5. [POS] Custom payment UI — Part 5 | Unit tests clean up

Steps to reproduce

Testing information

The tests that have been performed

Images/gif

• [ ] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• [ ] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• [ ] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• [ ] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

[dangermattic]

	1 Message
:book:	This PR is still a Draft: some checks will be skipped.

Generated by :no_entry_sign: Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	43c1f96a207eaabaff8374aad8a24f86f1a70619
	Direct Download	woocommerce-wear-prototype-build-pr12943-43c1f96.apk

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	43c1f96a207eaabaff8374aad8a24f86f1a70619
	Direct Download	woocommerce-prototype-build-pr12943-43c1f96.apk

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.93%. Comparing base (778491e) to head (bd7ad11).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## custom-payment-ui-4 #12943 +/- ## ====================================================== Coverage 39.93% 39.93% - Complexity 5993 5995 +2 ====================================================== Files 1266 1266 Lines 73238 73238 Branches 10006 10006 ====================================================== + Hits 29245 29250 +5 + Misses 41421 41418 -3 + Partials 2572 2570 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests