[Mobile Payments] Infinite loading receipt indicator

kidinov commented 2 days ago

Closes: #12949

Description

The PR closes the payment flow when fetching a receipt URL from the backend fails before initiation of the payment flow

This is not an optimal solution as we should probably get back to the "success" screen, but consider:

We start it after the view is recreated -> we would need to keep the previous state as the view model property, which may bring other issues with it
```
fun onViewCreated() {
    if (viewState.value is PrintingReceiptState) {
        startPrintingFlow()
    }
}
```
A user can easily print it from the order details
This probably won't happen too often

This is the easiest and good enough

Steps to reproduce

Create an order and add a product
Select Collect Payment and choose Card Reader option
Collect the payment
Tap on Print Receipt and notice a loading indicator is shown => it doesn't get dismissed when the network request to fetch the receipt fails (you can simulate this by disabling the internet connection on the device)

Testing information

Follow the steps to reproduce
Notice that the flow is closed now

The tests that have been performed

Images/gif

https://github.com/user-attachments/assets/53b07704-3039-43d4-9e77-4a1b1166a003

[x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[x] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[x] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[x] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

wpmobilebot commented 2 days ago

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	9d43402eabd47301c3e5b62d7d314e376f0a1a47
	Direct Download	`woocommerce-wear-prototype-build-pr12950-9d43402.apk`

wpmobilebot commented 2 days ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	9d43402eabd47301c3e5b62d7d314e376f0a1a47
	Direct Download	`woocommerce-prototype-build-pr12950-9d43402.apk`

codecov-commenter commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.76%. Comparing base (0cd474a) to head (9d43402). Report is 8 commits behind head on trunk.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #12950 +/- ## ========================================= Coverage 39.76% 39.76% Complexity 5961 5961 ========================================= Files 1262 1262 Lines 72940 72941 +1 Branches 9976 9976 ========================================= + Hits 29007 29008 +1 Misses 41356 41356 Partials 2577 2577 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

kidinov commented 1 day ago

@samiuelson could you please go through the checkboxes in the PR description 🙏

woocommerce / woocommerce-android