[Woo POS payments onboarding] Close SelectPaymentMethodFragment when we skip it in the WooPOS flow

kidinov commented 1 day ago

Closes: #12951

Description

The PR fixes a bug when during pos payment flow if onboarding not finished and a user goes back then we still were showing SelectPaymentMethodFragment

Steps to reproduce

Have a site with unfinished IPP onboarding
More -> POS -> Add a product -> Collect payment
Go back via the toolbar or system navigation
Notice loading indicator

The tests that have been performed

Above

Images/gif

https://github.com/user-attachments/assets/ac7913d8-34d0-4699-8f23-a2d07c05f67e

[x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[x] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[x] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[x] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

wpmobilebot commented 1 day ago

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	9a657e9063df3fc094bf3961a05e3bb6b1d0aaf7
	Direct Download	`woocommerce-wear-prototype-build-pr12952-9a657e9.apk`

wpmobilebot commented 1 day ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	9a657e9063df3fc094bf3961a05e3bb6b1d0aaf7
	Direct Download	`woocommerce-prototype-build-pr12952-9a657e9.apk`

woocommerce / woocommerce-android