woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

Remove unused `release.jks` from `.configure` #12955

Open wzieba opened 1 day ago

wzieba commented 1 day ago

Description

This file is not used anywhere in the project. It's a leftover, from times when configure tool was copying files from local .mobile-secrets repository, instead of decrypting them from .enc files (hence: encrypt: false)

Testing information

Double check that storeFile, storePassword properties or release.jks file are not used anywhere in the repository.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

dangermattic commented 1 day ago
1 Warning
:warning: This PR is assigned to the milestone 21.2. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 day ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commite1f9684a8eea479ccacff2e24b7e1cbbd4996691
Direct Downloadwoocommerce-wear-prototype-build-pr12955-e1f9684.apk
wpmobilebot commented 1 day ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commite1f9684a8eea479ccacff2e24b7e1cbbd4996691
Direct Downloadwoocommerce-prototype-build-pr12955-e1f9684.apk
ParaskP7 commented 8 hours ago

Btw, do you think we should do the same on the JP/WPAndroid too (.configure)? 🤔