woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

Rename deposits to payouts #12961

Closed malinajirka closed 6 hours ago

malinajirka commented 1 day ago

Closes: #12905

Description

After this PR, there should be minimal mentions of "deposit" in the app with the exceptions mentioned above.

Steps to reproduce

Testing information

I've tested the above and I double-checked a few stores to verify the numbers match the previous state.

Screenshots

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

dangermattic commented 1 day ago
1 Warning
:warning: View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
1 Message
:book:

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 day ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitbaf5b0ee320ef2055674b40f445c42c466f436b0
Direct Downloadwoocommerce-wear-prototype-build-pr12961-baf5b0e.apk
wpmobilebot commented 1 day ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitbaf5b0ee320ef2055674b40f445c42c466f436b0
Direct Downloadwoocommerce-prototype-build-pr12961-baf5b0e.apk
codecov-commenter commented 1 day ago

Codecov Report

Attention: Patch coverage is 26.24113% with 104 lines in your changes missing coverage. Please review.

Project coverage is 39.76%. Comparing base (7108661) to head (baf5b0e). Report is 104 commits behind head on trunk.

Files with missing lines Patch % Lines
.../hub/payoutsummary/PaymentsHubPayoutSummaryView.kt 0.00% 91 Missing :warning:
...youtsummary/PaymentsHubPayoutSummaryStateMapper.kt 52.63% 8 Missing and 1 partial :warning:
...ayoutsummary/PaymentsHubPayoutSummaryRepository.kt 57.14% 3 Missing :warning:
...e/android/ui/payments/hub/PaymentsHubViewHolder.kt 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #12961 +/- ## ============================================ - Coverage 39.76% 39.76% -0.01% Complexity 5961 5961 ============================================ Files 1262 1262 Lines 72941 72942 +1 Branches 9976 9976 ============================================ Hits 29008 29008 - Misses 41356 41357 +1 Partials 2577 2577 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

kidinov commented 6 hours ago

@malinajirka I pushed the renaming so it lands in 21.2

baf5b0ee320ef2055674b40f445c42c466f436b0