Fix ignored OrdersUITest

irfano commented 3 days ago

Description

OrdersUITest was ignored during toolbar refactoring process. Some parts of the order-related tests were addressed in #12906. This PR resolves the remaining issues with OrdersUITest.

Before, OrdersUITest was failing with the following error:

 androidx.test.espresso.AmbiguousViewMatcherException: 'view.getId() is <2131364783/com.woocommerce.android.dev:id/toolbar>' matches 2 views in the hierarchy:
- [1] MaterialToolbar{id=2131364783, res-name=toolbar, visibility=VISIBLE, width=1069, height=154, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, layout-params=com.google.android.material.appbar.CollapsingToolbarLayout$LayoutParams@YYYYYY, tag=null, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=-154.0, child-count=3}
- [2] MaterialToolbar{id=2131364783, res-name=toolbar, visibility=VISIBLE, width=1080, height=154, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, layout-params=android.widget.LinearLayout$LayoutParams@YYYYYY, tag=null, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=3}

This error was caused by duplicate toolbars on the screen. I'm not sure if this is optimal or not, but it falls outside the scope of this PR. To resolve the AmbiguousViewMatcherException, I used the first found toolbar to assert the toolbar title.

Steps to reproduce

Test OrdersUITest.

Testing information

The tests that have been performed

OrdersUITest

[x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[ ] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[ ] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[ ] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

wpmobilebot commented 3 days ago

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	e3a32352f1ba9df02ed918ccce0ab4c7c4950abd
	Direct Download	`woocommerce-wear-prototype-build-pr12963-e3a3235.apk`

wpmobilebot commented 3 days ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	e3a32352f1ba9df02ed918ccce0ab4c7c4950abd
	Direct Download	`woocommerce-prototype-build-pr12963-e3a3235.apk`

wpmobilebot commented 2 days ago

Version 21.2 has now entered code-freeze, so the milestone of this PR has been updated to 21.3.

woocommerce / woocommerce-android