Correct the file locations of promo texts in screenshots.json

irfano commented 1 day ago

Closes: https://github.com/woocommerce/woomobile-private/issues/393

Description

This fixes incorrect file locations for promo texts in screenshots.json. bundle exec fastlane download_promo_strings command downloads promo texts in metadata/android/{locale}/promo_screenshot_5.txt.

[!IMPORTANT]
This PR is based on the update-ruby-gems branch, as the issue with generating screenshots was resolved in release-toolkit version 12.3.3. Please ensure you test this PR using the correct version of the release-toolkit.

Testing information

Follow Android Screenshots instructions (P91TBi-8Pt-p2) to test generating promo screenshots.

The tests that have been performed

Generating promo screenshots with bundle exec fastlane create_promo_screenshot locales:en-US

Images/gif

[x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[ ] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[ ] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[ ] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

wpmobilebot commented 1 day ago

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	d92591f59bf0ba87660e3dce8e6e002d1791a1e0
	Direct Download	`woocommerce-wear-prototype-build-pr12965-d92591f.apk`

wpmobilebot commented 1 day ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	d92591f59bf0ba87660e3dce8e6e002d1791a1e0
	Direct Download	`woocommerce-prototype-build-pr12965-d92591f.apk`

woocommerce / woocommerce-android