woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

Fix dark mode issues #12966

Closed atorresveiga closed 4 hours ago

atorresveiga commented 19 hours ago

Part of: #12288

Description

This PR fixes two small issues in dark mode.

The first one is the purchase button elevation. In dark mode, the bottom section elevation differs from the bottom sheet, making the UI look weird. In this PR, I fix that by using different elevations depending on whether the device is in dark mode or expanded.

The second issue was the selected rate background in dark mode.

Testing information

  1. Create an Order with the processing status on a store that can create shipping labels
  2. Tap on Orders
  3. Tap on the order created on step 1
  4. Tap on create shipping labels
  5. Check that the shipment details section works as expected
  6. Tap on a shipping rate
  7. Check that the selected background is the expected
  8. Turn on dark mode
  9. Check the UI is readable and that the shipment section and the purchase button have the same elevation

The tests that have been performed

Images/gif

Before After

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

dangermattic commented 19 hours ago
1 Warning
:warning: This PR is assigned to the milestone 21.2. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

wpmobilebot commented 19 hours ago
πŸ“² You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit8d591c17cb9decf0be7f103ee883e768ccfad899
Direct Downloadwoocommerce-wear-prototype-build-pr12966-8d591c1.apk
wpmobilebot commented 18 hours ago

πŸ“² You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
PlatformπŸ“± Mobile
FlavorJalapeno
Build TypeDebug
Commit8d591c17cb9decf0be7f103ee883e768ccfad899
Direct Downloadwoocommerce-prototype-build-pr12966-8d591c1.apk
codecov-commenter commented 18 hours ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.73%. Comparing base (16feecf) to head (8d591c1). Report is 5 commits behind head on trunk.

Files with missing lines Patch % Lines
...i/orders/wooshippinglabels/ShippingRatesSection.kt 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #12966 +/- ## ============================================ - Coverage 39.73% 39.73% -0.01% Complexity 5983 5983 ============================================ Files 1267 1267 Lines 73223 73224 +1 Branches 10041 10042 +1 ============================================ Hits 29094 29094 - Misses 41563 41564 +1 Partials 2566 2566 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: