Fix unresponsive email icon from customer details screen

JorgeMucientes commented 3 days ago

Closes: #12954

Description

Steps to reproduce

From trunk

Navigate to more menu
Click on customers item
Open a customer detail item
Click on the email icon
Verify nothing happens

Testing information

Repeat the above steps. This time tapping on the email icon will open the email app ready to compose a new email with the customer's address. If not email client app installed, the app will show a toast stating "No e-mail app was found"

The tests that have been performed

The above

Images/gif

https://github.com/user-attachments/assets/3b6a1c35-eed2-4103-9d12-2177c3f25c2f

[x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[ ] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[ ] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[ ] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

dangermattic commented 3 days ago

	1 Warning
:warning:	This PR is assigned to the milestone 21.2. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 days ago

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	3e1707edfcaeb2e09b63dbb87a0566f453907203
	Direct Download	`woocommerce-wear-prototype-build-pr12968-3e1707e.apk`

wpmobilebot commented 3 days ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	3e1707edfcaeb2e09b63dbb87a0566f453907203
	Direct Download	`woocommerce-prototype-build-pr12968-3e1707e.apk`

codecov-commenter commented 3 days ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 39.72%. Comparing base (81b12c9) to head (3e1707e). Report is 33 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...d/ui/moremenu/customer/CustomerDetailsViewModel.kt	0.00%	3 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #12968 +/- ## ============================================ - Coverage 39.73% 39.72% -0.01% + Complexity 5985 5984 -1 ============================================ Files 1268 1268 Lines 73252 73255 +3 Branches 10061 10061 ============================================ - Hits 29106 29103 -3 - Misses 41564 41569 +5 - Partials 2582 2583 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

woocommerce / woocommerce-android