woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

Fix ScreenshotTest for different locales #12979

Open irfano opened 8 hours ago

irfano commented 8 hours ago

Closes: #https://github.com/woocommerce/woomobile-private/issues/393

Description

ScreenshotTest was failing when the language is set to Arabic or French. This PR fixes these failures.

[!IMPORTANT]
Do not merge now, we'll merge this as a beta fix for 21.2.

Steps to reproduce

  1. Set the device language to Arabic (ar).
  2. Run ScreenshotTest.
  3. Set the device language to French (fr-FR).
  4. Run ScreenshotTest.

The tests that have been performed

ScreenshotTest

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

dangermattic commented 8 hours ago
2 Errors
:no_entry_sign: This PR is tagged with status: do not merge label(s).
:no_entry_sign: PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

wpmobilebot commented 8 hours ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit2e5ee714e4aaf2e1ea2f0e4f76fd26945616c7e1
Direct Downloadwoocommerce-wear-prototype-build-pr12979-2e5ee71.apk
wpmobilebot commented 8 hours ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit2e5ee714e4aaf2e1ea2f0e4f76fd26945616c7e1
Direct Downloadwoocommerce-prototype-build-pr12979-2e5ee71.apk