search

woocommerce / woocommerce-blocks

(Deprecated) This plugin has been merged into woocommerce/woocommerce
https://wordpress.org/plugins/woo-gutenberg-products-block/
GNU General Public License v3.0
405 stars 219 forks source link

Deprecated: Function WP_Scripts::print_inline_script is deprecated since version 6.3.0! Use WP_Scripts::get_inline_script_data() or WP_Scripts::get_inline_script_tag() instead. #10392

Closed BackuPs closed 1 year ago

BackuPs commented 1 year ago

Prerequisites

Describe the bug

I get this message when woocommerce is active in wp 6.3

Deprecated: Function WP_Scripts::print_inline_script is deprecated since version 6.3.0! Use WP_Scripts::get_inline_script_data() or WP_Scripts::get_inline_script_tag() instead. in /var/docs/server.tst/public/wp-includes/functions.php on line 5452

When i turn off woocommerce it is gone

It is coming from woocommerce blocks minicart.php line 356 and 357

Please fix.

Expected behavior

Please adjust the function call to get_inline_script_data

Actual behavior

See error message

Steps to reproduce

Just install latest trunk wp 6.3 and activate woocommerce. Turn on php warnings and try to login. You will see the deprecated mesaage

WordPress Environment

`

WordPress Environment

WordPress address (URL): http://server.tst Site address (URL): http://server.tst WC Version: 7.9.0 REST API Version: ✔ 7.9.0 WC Blocks Version: ✔ 10.4.5 Action Scheduler Version: ✔ 3.6.1 Log Directory Writable: ✔ WP Version: 6.3 WP Multisite: – WP Memory Limit: 512 MB WP Debug Mode: ✔ WP Cron: ✔ Language: en_US External object cache: –

Server Environment

Server Info: Apache/2.4.41 (Ubuntu) PHP Version: 8.0.29 PHP Post Max Size: 128 MB PHP Time Limit: 600 PHP Max Input Vars: 5000 cURL Version: 7.68.0 OpenSSL/1.1.1f

SUHOSIN Installed: – MySQL Version: 8.0.33-0ubuntu0.20.04.2 Max Upload Size: 128 MB Default Timezone is UTC: ✔ fsockopen/cURL: ✔ SoapClient: ❌ Your server does not have the SoapClient class enabled - some gateway plugins which use SOAP may not work as expected. DOMDocument: ✔ GZip: ✔ Multibyte String: ✔ Remote Post: ✔ Remote Get: ✔

Database

WC Database Version: 7.2.0 WC Database Prefix: wp_ Total Database Size: 29.09MB Database Data Size: 19.52MB Database Index Size: 9.57MB wp_woocommerce_sessions: Data: 0.11MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_api_keys: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_attribute_taxonomies: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_downloadable_product_permissions: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_woocommerce_order_items: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_order_itemmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_tax_rates: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_woocommerce_tax_rate_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_shipping_zones: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_woocommerce_shipping_zone_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_shipping_zone_methods: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_woocommerce_payment_tokens: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_payment_tokenmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_log: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_actionscheduler_actions: Data: 0.02MB + Index: 0.11MB + Engine InnoDB wp_actionscheduler_claims: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_actionscheduler_groups: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_actionscheduler_logs: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_aioseo_cache: Data: 0.11MB + Index: 0.03MB + Engine InnoDB wp_aioseo_notifications: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_aioseo_posts: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_commentmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_comments: Data: 0.02MB + Index: 0.09MB + Engine InnoDB wp_e_events: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_e_submissions: Data: 0.02MB + Index: 0.23MB + Engine InnoDB wp_e_submissions_actions_log: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_e_submissions_values: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_eg_grids: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_eg_item_elements: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_eg_item_skins: Data: 0.08MB + Index: 0.03MB + Engine InnoDB wp_eg_navigation_skins: Data: 0.14MB + Index: 0.02MB + Engine InnoDB wp_fbv: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_fbv_attachment_folder: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_icl_background_task: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_icl_content_status: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_icl_core_status: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_icl_flags: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_icl_languages: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_icl_languages_translations: Data: 0.20MB + Index: 0.17MB + Engine InnoDB wp_icl_locale_map: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_icl_message_status: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_icl_mo_files_domains: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_icl_node: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_icl_reminders: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_icl_string_batches: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_icl_string_packages: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_icl_string_positions: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_icl_string_status: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_icl_string_translations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_icl_strings: Data: 2.52MB + Index: 4.33MB + Engine InnoDB wp_icl_translate: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_icl_translate_job: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_icl_translation_batches: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_icl_translation_downloads: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_icl_translation_status: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_icl_translations: Data: 0.08MB + Index: 0.22MB + Engine InnoDB wp_links: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_options: Data: 7.02MB + Index: 0.08MB + Engine InnoDB wp_postmeta: Data: 4.41MB + Index: 1.94MB + Engine InnoDB wp_posts: Data: 2.42MB + Index: 0.22MB + Engine InnoDB wp_responsive_menu: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_responsive_menu_pro: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_revslider_css: Data: 0.13MB + Index: 0.02MB + Engine InnoDB wp_revslider_css_bkp: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_revslider_layer_animations: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_revslider_layer_animations_bkp: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_revslider_navigations: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_revslider_navigations_bkp: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_revslider_sliders: Data: 0.03MB + Index: 0.02MB + Engine InnoDB wp_revslider_sliders_bkp: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_revslider_slides: Data: 0.13MB + Index: 0.02MB + Engine InnoDB wp_revslider_slides_bkp: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_revslider_static_slides: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_revslider_static_slides_bkp: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_term_relationships: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_term_taxonomy: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_termmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_terms: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_usermeta: Data: 0.05MB + Index: 0.03MB + Engine InnoDB wp_users: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_wc_admin_note_actions: Data: 0.06MB + Index: 0.02MB + Engine InnoDB wp_wc_admin_notes: Data: 0.06MB + Index: 0.00MB + Engine InnoDB wp_wc_category_lookup: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_wc_customer_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_download_log: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_order_coupon_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_order_product_lookup: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_wc_order_stats: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_wc_order_tax_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_product_attributes_lookup: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_product_download_directories: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_product_meta_lookup: Data: 0.02MB + Index: 0.09MB + Engine InnoDB wp_wc_rate_limits: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_reserved_stock: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_wc_tax_rate_classes: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_webhooks: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_yoast_indexable: Data: 0.11MB + Index: 0.09MB + Engine InnoDB wp_yoast_indexable_hierarchy: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_yoast_migrations: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_yoast_primary_term: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_yoast_seo_links: Data: 0.20MB + Index: 0.20MB + Engine InnoDB

Post Type Counts

attachment: 408 customize_changeset: 2 elementor_library: 3 nav_menu_item: 105 page: 125 portfolio: 30 post: 19 preset: 3 product: 18 product_variation: 7 revision: 317 slideshow: 5 wp_navigation: 1

Security

Secure connection (HTTPS): ❌ Your store is not using HTTPS. Learn more about HTTPS and SSL Certificates. Hide errors from visitors: ❌Error messages should not be shown to visitors.

Active Plugins (15)

Design Plus Responsive Menu: by The Themebuilders – 3.1.38 Elementor: by Elementor.com – 3.14.1 ElementsKit Lite: by Wpmet – 2.9.0 ElementsKit Pro: by Wpmet – 3.2.1 Envato Theme Check: by Scott Parry – 1.0.0 Essential Grid: by ThemePunch – 3.0.17.1 FileBird Pro: by Ninja Team – 5.4.4 Flexible Elementor Panel: by WebMat – 2.3.9 PRO Elements: by PROElements.org – 3.14.0 Slider Revolution: by ThemePunch – 6.6.14 Widget Importer & Exporter: by ChurchThemes.com – 1.6.1 WooCommerce Beta Tester: by WooCommerce – 2.1.0 WooCommerce: by Automattic – 7.9.0-rc.2 WordPress Beta Tester: by WordPress Upgrade/Install Team – 3.5.0 Yoast SEO: by Team Yoast – 20.10

Inactive Plugins (33)

Akismet Anti-Spam: Spam Protection: by Automattic - Anti Spam Team – 5.2 All in One SEO: by All in One SEO Team – 4.4.0.1 bbPress: by The bbPress Contributors – 2.6.9 Champion Responsive Menu: by The ThemeBuilders – 3.1.39 Classic Editor: by WordPress Contributors – 1.6.3 Disable Author Pages: by Frank Staude – 0.11 Elementor Pro: by Elementor.com – 3.6.4 Element Pack Lite - Addons for Elementor: by BdThemes – 5.1.3 Element Pack Pro: by BdThemes – 7.0.1 Enable jQuery Migrate Helper: by The WordPress Team – 1.3.0 Fancy Product Designer: by fancyproductdesigner.com – 4.6.7 Fancy Product Designer: by fancyproductdesigner.com – 4.6.9 Fancy Product Designer Plus: by fancyproductdesigner.com – 1.3.0 Fancy Product Designer REST API: by fancyproductdesigner.com – 1.6.4 Google Analytics for WordPress by MonsterInsights: by MonsterInsights – 8.17 Gravity Forms: by Gravity Forms – 2.6.7 Gutenberg: by Gutenberg Team – 16.1.1 Multiflex Responsive Menu: by The Themebuilders – 3.1.38 OoohBoi Steroids for Elementor: by OoohBoi – 2.1.5 QuadMenu: by QuadLayers – 3.0.2 QuadMenu PRO: by Mega Menu – 1.9.0 Quform: by ThemeCatcher – 2.14.2 Replace Google Fonts with Bunny Fonts: by antonioleutsch – 2.1.2 Responsive Menu: by ExpressTech – 4.3.0 Reveal IDs: by Oliver Schlöbe – 1.5.5 RTL Tester: by Yoav Farhi Automattic – 1.2

Striking_R Framework Extension: by kaptinlin – 2.2.1 Super Elements for Elementor: by ThemeRevealed – 2.2.7 WooCommerce Multilingual & Multicurrency: by OnTheGoSystems – 5.1.3 WP-PageNavi: by Lester 'GaMerZ' Chan – 2.94.1 WPML Media: by OnTheGoSystems – 2.7.2 WPML Multilingual CMS: by OnTheGoSystems – 4.6.3 WPML String Translation: by OnTheGoSystems – 3.2.5

Settings

API Enabled: – Force SSL: – Currency: EUR (€) Currency Position: left_space Thousand Separator: . Decimal Separator: , Number of Decimals: 2 Taxonomies: Product Types: external (external) grouped (grouped) simple (simple) variable (variable)

Taxonomies: Product Visibility: exclude-from-catalog (exclude-from-catalog) exclude-from-search (exclude-from-search) featured (featured) outofstock (outofstock) rated-1 (rated-1) rated-2 (rated-2) rated-3 (rated-3) rated-4 (rated-4) rated-5 (rated-5)

Connected to WooCommerce.com: – Enforce Approved Product Download Directories: ✔ HPOS feature screen enabled: – HPOS feature enabled: – Order datastore: WC_Order_Data_Store_CPT HPOS data sync enabled: –

WC Pages

Shop base: woocommerce/woocommerce#5895 - /shop Cart: woocommerce/woocommerce#5896 - /cart Checkout: woocommerce/woocommerce#5897 - /checkout My account: woocommerce/woocommerce#5898 - /my-account Terms and conditions: ❌ Page not set

Theme

Name: WP Champion Professional Theme Version: 3.7.0 Author URL: https://thethemebuilders.com/about Child Theme: ❌ – If you are modifying WooCommerce on a parent theme that you did not build personally we recommend using a child theme. See: How to create a child theme WooCommerce Support: ✔

Templates

Overrides: champion/woocommerce/archive-product.php champion/woocommerce/content-product-cat.php champion/woocommerce/content-product.php champion/woocommerce/global/breadcrumb.php champion/woocommerce/product-searchform.php champion/woocommerce/single-product/meta.php champion/woocommerce/single-product/product-image.php champion/woocommerce/single-product/product-thumbnails.php champion/woocommerce/single-product/related.php champion/woocommerce/single-product/tabs/additional-information.php champion/woocommerce/single-product/tabs/description.php champion/woocommerce/single-product/tabs/tabs.php champion/woocommerce/single-product/title.php champion/woocommerce/single-product/up-sells.php champion/woocommerce/single-product-reviews.php champion/woocommerce/single-product.php champion/woocommerce/content-product_cat.php

Admin

Enabled Features: activity-panels analytics product-block-editor coupons core-profiler customer-effort-score-tracks import-products-task experimental-fashion-sample-products shipping-smart-defaults shipping-setting-tour homescreen marketing mobile-app-banner navigation onboarding onboarding-tasks remote-inbox-notifications remote-free-extensions payment-gateway-suggestions shipping-label-banner subscriptions store-alerts transient-notices woo-mobile-welcome wc-pay-promotion wc-pay-welcome-page

Disabled Features: minified-js new-product-management-experience product-variation-management settings async-product-editor-category-field

Daily Cron: ✔ Next scheduled: 2022-10-19 09:48:32 +00:00 Options: ✔ Notes: 97 Onboarding: completed

Action Scheduler

Complete: 6 Oldest: 2023-05-03 06:35:37 +0000 Newest: 2023-05-03 06:36:10 +0000

Pending: 20 Oldest: 2023-04-11 04:20:14 +0000 Newest: 2023-05-24 05:19:34 +0000

Canceled: 2 Oldest: -0001-11-30 00:00:00 +0000 Newest: -0001-11-30 00:00:00 +0000

Status report information

Generated at: 2023-07-05 09:18:18 +00:00 `

Isolating the problem

nbase-apsleyfarms commented 1 year ago

Also getting this running PHP 8.1

strategio commented 1 year ago

I am having the same problem with WP 6.3 RC1 (and of course WC 7.9.0).

webmandesign commented 1 year ago

The same issue here.

shuvo586 commented 1 year ago

same issue here ( 6.3-RC1 )

rrennick commented 1 year ago

@BackuPs I'm not seeing this with 6.3 RC2 and WC 8.0.0 beta2? Can you confirm whether you still see it?

Programmer095 commented 1 year ago

@rrennick I'm still seeing the issues with 6.3 RC2 and WC 8.0.0 beta2. If you have WooCo active and perform any action that loads the block editor (such as opening a post for editing) it fills the log with the entries noted above.

Chouby commented 1 year ago

A quick search in the code show where there are: https://github.com/search?q=repo%3Awoocommerce%2Fwoocommerce-blocks%20print_inline_script&type=code

andreiglingeanu commented 1 year ago

I still see this with 6.3RC2 and WC 8.0.0 beta2 on the frontend of the website unfortunately. Is there any way we could help fix this problem?

Aljullu commented 1 year ago

Hey there, thanks for reporting this issue and expressing your interest! It was fixed in https://github.com/woocommerce/woocommerce-blocks/pull/10165 and we are planning to include it in WooCommerce 8.0-rc1.

If the issue is affecting your site and you need the fix sooner, you can install WC Blocks 10.7.1, where the issue is already fixed.

Hope that helps! I will go ahead and close this issue. :slightly_smiling_face:

andreiglingeanu commented 1 year ago

Thanks a lot! Can confirm that installing WC Blocks 10.7.1 fixes this problem.

Ged2323 commented 8 months ago

I updated my WooCommerce plugin and the error went away. WooCommerce Version 8.5.1 my error was -> Deprecated: Function WP_Scripts::print_inline_script is deprecated since version 6.3.0! Use WP_Scripts::get_inline_script_data() or WP_Scripts::get_inline_script_tag() instead. in /---/---/public_html/wp-includes/functions.php on line 6031