woocommerce / woocommerce-blocks

(Deprecated) This plugin has been merged into woocommerce/woocommerce
https://wordpress.org/plugins/woo-gutenberg-products-block/
GNU General Public License v3.0
406 stars 219 forks source link

Add term classes #1189

Closed strarsis closed 3 years ago

strarsis commented 5 years ago

Is your feature request related to a problem? Please describe. There are classes missing for blocks like the category list.

Describe the solution you'd like Add classes for term slug/ID to each category list item.

Describe alternatives you've considered There aren't really any alternatives, there aren't dedicated filters either.

issue-label-bot[bot] commented 5 years ago

Issue-Label Bot is automatically applying the label type: feature request to this issue, with a confidence of 0.98. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

ralucaStan commented 3 years ago

Hi @strarsis to move this forward we need additional information from your side.

Thank you!

github-actions[bot] commented 3 years ago

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.
github-actions[bot] commented 3 years ago

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.
github-actions[bot] commented 3 years ago

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.
strarsis commented 3 years ago

Finally I arrive answering the questions: Product Categories List Block. class should be the slug of the category term, as with the traditional shortcode markup.

nielslange commented 3 years ago

class should be the slug of the category term, as with the traditional shortcode markup.

@strarsis By "traditional shortcode markup", are you referring to the [product_categories] shortcode? I'm asking as when applying this shortcode and using the Storefront theme, I do not see the category terms used as term classes:

<ul class="products columns-4">
    <li class="product-category product first">
        <a href="https://store.local/product-category/clothing/">
            <img src="https://store.local/wp-content/uploads/woocommerce-placeholder-324x324.png" alt="Clothing" width="324" height="324">
            <h2 class="woocommerce-loop-category__title">Clothing <mark class="count">(14)</mark> </h2>
        </a>
    </li>
    <li class="product-category product">
        <a href="https://store.local/product-category/decor/">
            <img src="https://store.local/wp-content/uploads/woocommerce-placeholder-324x324.png" alt="Decor" width="324" height="324">
            <h2 class="woocommerce-loop-category__title">Decor <mark class="count">(1)</mark></h2>
        </a>
    </li>
    <li class="product-category product">
        <a href="https://store.local/product-category/music/">
            <img src="https://store.local/wp-content/uploads/woocommerce-placeholder-324x324.png" alt="Music" width="324" height="324">
            <h2 class="woocommerce-loop-category__title">Music <mark class="count">(2)</mark> </h2>
        </a>
    </li>
</ul>
nielslange commented 3 years ago

@strarsis I’m going to close this because there still isn’t anything actionable for us on this issue. If/when you have additional details, you can still add them to this issue and if we’re able to reproduce, we can re-open as necessary.