Closed mikejolley closed 4 years ago
Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.
Essentially, source is the shipping method ID, and id is the shipping method instance ID used internally.
Would it be clearer to name this field => source
method
to match the name in the UI, Shipping method
?
Do we need to include taxes like core does or is there a better way to calculate/surface this data? Does price include or exclude taxes?
Good question – I'm not familiar with how taxes apply to shipping, I'm guessing that's complex and subtle. What does the design call for?
Handling time is not something included in core; how do we expose this to users/developers?
This feels like an extra feature in the new cart layout – one option would be that we add this later as an enhancement (either in this cycle or later). Is there any existing support for handling time / shipping ETA estimate in core, or are we building this brand new for the optimised checkout/block UX?
I see it's in the existing mockups, how important is handling time/shipping ETA for v1 @garymurray @pmcpinto ?
This feels like an extra feature in the new cart layout – one option would be that we add this later as an enhancement (either in this cycle or later). Is there any existing support for handling time / shipping ETA estimate in core, or are we building this brand new for the optimised checkout/block UX? I see it's in the existing mockups, how important is handling time/shipping ETA for v1 @garymurray @pmcpinto ?
Shipping time seems to be more a nice to have and if it doesn't exist in core it's better to backlog it and see if we have time to tackle this at the end of the cycle or in the upcoming one.
Do we need to include taxes like core does or is there a better way to calculate/surface this data? Does price include or exclude taxes?
I think that it will be better to stick with the behavior on core.
@garymurray what do you think about both questions?
Shipping times
This was a recommended item via Baymard - so it would be nice to include, but is not a critical feature for v1 - it can be backlogged.
Taxes Do we need to include taxes like core does or is there a better way to calculate/surface this data? Does price include or exclude taxes?
Just to check you are referring to when their is an additional line item in the cart called Taxes
here? I think for now we can just create an additional line item for this in the cart totals - like this:
Just to check you are referring to when their is an additional line item in the cart called Taxes here? I think for now we can just create an additional line item for this in the cart totals - like this:
Thinking about the API not the design; it comes down to when the tax calculations need to occur. Are the taxes returned from the shipping endpoint, or are the taxes calculated later when putting together the final total.
Shipping time seems to be more a nice to have and if it doesn't exist in core it's better to backlog it and see if we have time to tackle this at the end of the cycle or in the upcoming one.
I think it's best to allow for it in the API. Implementing it would require changes to the core shipping methods, so there will be no movement unless supported, somewhere.
Thinking about the API not the design; it comes down to when the tax calculations need to occur. Are the taxes returned from the shipping endpoint, or are the taxes calculated later when putting together the final total.
How is this handled by Core currently - afaik the taxes are based on an entered/captured location - so it requires someone to have added or confirmed their location?
I think it's best to allow for it in the API. Implementing it would require changes to the core shipping methods, so there will be no movement unless supported, somewhere.
👍
Takes a shipping address and returns a list of available shipping rates for the current cart.
GET /cart/shipping-rates
The shipping address schema can be borrowed from the core REST API, and includes the following:
Also for reference, core shipping rates contain this data:
Example:
GET /cart/shipping-rates?country=US&postcode=90210&city
Response:
I'm thinking this naming will make more sense in an API. Essentially,
source
is the shipping method ID, andid
is the shipping method instance ID used internally.Questions:
taxes
like core does or is there a better way to calculate/surface this data? Doesprice
include or exclude taxes?Tasks:
handling_time
field which doesn't exist in core but could be supported/added separately.