search

woocommerce / woocommerce-blocks

(Deprecated) This plugin has been merged into woocommerce/woocommerce
https://wordpress.org/plugins/woo-gutenberg-products-block/
GNU General Public License v3.0
403 stars 218 forks source link

"By proceeding with your purchase [...]" Not Translated on Checkout Block #5005

Closed igotdes closed 2 years ago

igotdes commented 2 years ago

Describe the bug

When using the Checkout block, "By proceeding with your purchase you agree to our Terms and Conditions and Privacy Policy" is not being translated even if translations for it exist.

To reproduce

Steps to reproduce the behavior:

  1. On WP Admin > Settings, set the Site Language to a language other than English like Español or Norsk bokmål.
  2. Make sure to download any translation updates under My Home > Updates
  3. Create a page, add the Checkout block to it, and save it
  4. Add a product to cart and view the checkout page created previously

Expected behavior

"By proceeding with your purchase you agree to our Terms and Conditions and Privacy Policy" should be translated.

Screenshots

Español - translation here Translation-Checkout-Block-ES

Norsk bokmål - translation here Translation-Checkout-Block-NO

Environment

WordPress:

Desktop (please complete the following information):

Additional context

Reported in #4406259-zen.

nielslange commented 2 years ago

Hello @igotdes 👋

Thanks for reporting this problem. I looked up this case and found out that the string in question was using the textdomain woo-gutenberg-product-blocks instead of the textdomain woo-gutenberg-products-blocks (note the missing s for products). Therefore, the available translations couldn't be picked up.

I created a fix for this problem with #5020. This fix needs to be reviewed first, then approved, then merged and finally shipped. I cannot give you an estimate yet, on when the fix will be shipped. However, in case the client is looking for a quick solution, you could suggest changing the string directly within the checkout block, as the string is editable:

Screen Shot 2021-10-28 at 11 06 50
nielslange commented 2 years ago

@igotdes The problem you reported had been resolved. Would you mind informing the client accordingly?

igotdes commented 2 years ago

@igotdes The problem you reported had been resolved. Would you mind informing the client accordingly?

Done! I've informed the user.

Thanks for working on this and for keeping me updated too, @nielslange!

nielslange commented 2 years ago

Thank you for reaching out to the user, @igotdes! 🙌