search

woocommerce / woocommerce-blocks

(Deprecated) This plugin has been merged into woocommerce/woocommerce
https://wordpress.org/plugins/woo-gutenberg-products-block/
GNU General Public License v3.0
406 stars 218 forks source link

Consider alternatives to having attributes in `block.json` and `attributes.ts` #5652

Closed opr closed 2 years ago

opr commented 2 years ago

In #5594 we moved most of the attributes out of attributes.ts into metadata in block.json, this was done to align ourselves more closely with Gutenberg principles. Some of our attributes rely on the evaluation of getSetting from '@woocommerce/settingsso therefore cannot be included inblock.json`.

This issue is for discussing ways around this and to track a fix or alternative approach for it.

github-actions[bot] commented 2 years ago

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.