search

woocommerce / woocommerce-blocks

(Deprecated) This plugin has been merged into woocommerce/woocommerce
https://wordpress.org/plugins/woo-gutenberg-products-block/
GNU General Public License v3.0
406 stars 219 forks source link

The Empty Cart block does not show translated texts #5968

Closed ralucaStan closed 2 years ago

ralucaStan commented 2 years ago

Describe the bug

The Empty Cart block does not show translated texts

This bug was found while testing https://github.com/woocommerce/woocommerce-gutenberg-products-block/pull/5910

To reproduce

  1. Go to Settings > General > Language (/wp-admin/options-general.php) and select a language which has WC core translation at 100% but WC Blocks' at 0%. (I tested with Català).
  2. Go to the updates screen (/wp-admin/update-core.php), scroll down and update the language translations.
  3. Visit the Empty Cart block and notice the texts are not translated
  4. Visit the Cart or Checkout block in the frontend and verify the texts are translated.

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

Screenshot 2022-03-01 at 09 52 21
github-actions[bot] commented 2 years ago

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.
masteradhoc commented 2 years ago

@ralucaStan isnt this fixed already?

ralucaStan commented 2 years ago

Hey @masteradhoc, thank you for reaching out. We didn't get a chance to look into this yet. But we did find a similar issue that was fixed following the steps from this comment. Would you mind trying that and let us know if that solves your issue?

senadir commented 2 years ago

Empty Cart uses core blocks (heading, paragraph...) and the value of those fields is hard-coded into the page, they will reflect the language you had when you inserted the block. This is the same if you have multilanguage content pages, treat the empty cart as a static page.

image

For most translation engines (WPML, Polylang, TranslatePress) they provide the option to duplicate a page between langauges.

senadir commented 2 years ago

Raluca, I'm going to close this because there's nothing to fix here.