woocommerce / woocommerce-blocks

(Deprecated) This plugin has been merged into woocommerce/woocommerce
https://wordpress.org/plugins/woo-gutenberg-products-block/
GNU General Public License v3.0
405 stars 218 forks source link

WC-blocks dutch checkout #8531

Closed Moosinams closed 1 year ago

Moosinams commented 1 year ago

What do you like about the Cart & Checkout blocks?

Realy better as standard woocommerce

What do you think is missing from the Cart & Checkout blocks?

I miss a few Dutch translations, Add a coupon=Kortingscode , Please enter a valid=Vul a.u.b. juist in: And City names in Holland kan start with a ' , like 's-Hertogenbosch.

nielslange commented 1 year ago

Hello @Moosinams 👋

Thanks for reaching out! (Oftewel bedankt voor je bericht! 😁) I'll switch back to English, so that others can follow the conversation.

Realy better as standard woocommerce

That's great to hear. Is there any specific you like better with the new Cart and Checkout blocks? I'm just curious.

I miss a few Dutch translations, Add a coupon=Kortingscode , Please enter a valid=Vul a.u.b. juist in:

Please note that translations are handled by volunteers. Looking at https://translate.wordpress.org/projects/wp-plugins/woo-gutenberg-products-block/, you can imagine why it's almost impossible for us to translate WooCommerce Blocks into every language. That said, the Dutch translators are usually rather quick in providing translations. In addition, to relying on someone else to provide a translation, you can also become a translation contributor. On https://make.wordpress.org/polyglots/handbook/translating/glotpress-translate-wordpress-org/#getting-started you can find information on how to get started. Once you've submitted translations, they need to be approved by a translation editor.

And City names in Holland kan start with a ' , like 's-Hertogenbosch.

I just ran a quick test and saw that it's possible to place an order when using the city name 's-Hertogenbosch. That said, when placing a second order, I see that 's-Hertogenbosch changed to ‘s-Hertogenbosch. That's indeed not the correct city name. I created https://github.com/woocommerce/woocommerce-blocks/issues/8533 to track this issue.

I'll close this issue for now, as there are no action points, but you are welcome to create another issue if you have any more questions or suggestions. We always welcome any kind of feedback! 😀

Moosinams commented 1 year ago

Hi Niels,

Thank you for your quick reaction. Regarding the apostrophe, I had the same, maybe I had to fill in a new address to check better, thnx for starting 8533.

I will have a look, to help in the translations.

Have a nice weekend.

Grtz Moos

Op vr 24 feb. 2023 om 13:05 schreef Niels Lange @.***>:

Hello @Moosinams https://github.com/Moosinams 👋

Thanks for reaching out! (Oftewel bedankt voor je bericht! 😁) I'll switch back to English, so that others can follow the conversation.

Realy better as standard woocommerce

That's great to hear. Is there any specific you like better with the new Cart and Checkout blocks? I'm just curious.

I miss a few Dutch translations, Add a coupon=Kortingscode , Please enter a valid=Vul a.u.b. juist in:

Please note that translations are handled by volunteers. Looking at https://translate.wordpress.org/projects/wp-plugins/woo-gutenberg-products-block/, you can imagine why it's almost impossible for us to translate WooCommerce Blocks into every language. That said, the Dutch translators are usually rather quick in providing translations. In addition, to relying on someone else to provide a translation, you can also become a translation contributor. On https://make.wordpress.org/polyglots/handbook/translating/glotpress-translate-wordpress-org/#getting-started you can find information on how to get started. Once you've submitted translations, they need to be approved by a translation editor.

And City names in Holland kan start with a ' , like 's-Hertogenbosch.

I just ran a quick test and saw that it's possible to place an order when using the city name 's-Hertogenbosch. That said, when placing a second order, I see that 's-Hertogenbosch changed to ‘s-Hertogenbosch. That's indeed not the correct city name. I created #8533 https://github.com/woocommerce/woocommerce-blocks/issues/8533 to track this issue.

I'll close this issue for now, as there are no action points, but you are welcome to create another issue if you have any more questions or suggestions. We always welcome any kind of feedback! 😀

— Reply to this email directly, view it on GitHub https://github.com/woocommerce/woocommerce-blocks/issues/8531#issuecomment-1443593196, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6DF7F4TPQBZ6KY65AONF5LWZCPYVANCNFSM6AAAAAAVGX24NM . You are receiving this because you were mentioned.Message ID: @.***>

nielslange commented 1 year ago

Hi Moss,

Thank you for your quick reaction. Regarding the apostrophe, I had the same, maybe I had to fill in a new address to check better, thnx for starting #8533.

I believe that the apostrophe should be kept, as it's part of the official name. That said, I started a discussion within our team to discuss this.

I will have a look, to help in the translations.

That's great to hear. I'm actually one of the Translation Editors for Dutch and can approve translations. I'll keep an eye on translation submissions so that they can go live as soon as possible.

I also wish you a great weekend, Moos! 🙌

Moosinams commented 1 year ago

Hi Niels,

Ik zag al mooi vertalingen langskomen, geweldig !

Mag ik je nog een vraagstellen over de blocks. Ik krijg bijgevoegde foutmelding bij het invullen. Weet jij hoe dit komt?

Groet Moos

Op vr 24 feb. 2023 om 13:35 schreef Niels Lange @.***>

Hi Moss,

Thank you for your quick reaction. Regarding the apostrophe, I had the same, maybe I had to fill in a new address to check better, thnx for starting #8533 https://github.com/woocommerce/woocommerce-blocks/issues/8533.

I believe that the apostrophe should be kept, as it's part of the official name. That said, I started a discussion within our team to discuss this.

I will have a look, to help in the translations.

That's great to hear. I'm actually one of the Translation Editors for Dutch and can approve translations. I'll keep an eye on translation submissions so that they can go live as soon as possible.

I also wish you a great weekend, Moos! 🙌

— Reply to this email directly, view it on GitHub https://github.com/woocommerce/woocommerce-blocks/issues/8531#issuecomment-1443626223, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6DF7FZCOTSGQL5ZS423PPTWZCTKNANCNFSM6AAAAAAVGX24NM . You are receiving this because you were mentioned.Message ID: @.***>

nielslange commented 1 year ago

Hi Moos,

Mag ik je nog een vraagstellen over de blocks. Ik krijg bijgevoegde foutmelding bij het invullen. Weet jij hoe dit komt?

Let's try to communicate in English, so that others, that might face the same problem, can follow the discussion. You were asking if you can ask another question regarding the blocks and that you're seeing an error message. It appears that the error message hasn't been transferred to GitHub. I assume that this issue is unrelated to this issue. Could you go ahead, create a new issue, describe the problem you're facing and add steps on how to reproduce the problem?

Moosinams commented 1 year ago

Tnx Niels, I will try 👍

Op vr 24 mrt. 2023 om 11:08 schreef Niels Lange @.***>

Hi Moos,

Mag ik je nog een vraagstellen over de blocks. Ik krijg bijgevoegde foutmelding bij het invullen. Weet jij hoe dit komt?

Let's try to communicate in English, so that others, that might face the same problem, can follow the discussion. You were asking if you can ask another question regarding the blocks and that you're seeing an error message. It appears that the error message hasn't been transferred to GitHub. I assume that this issue is unrelated to this issue. Could you go ahead, create a new issue, describe the problem you're facing and add steps on how to reproduce the problem?

— Reply to this email directly, view it on GitHub https://github.com/woocommerce/woocommerce-blocks/issues/8531#issuecomment-1482552375, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6DF7F7DGG5KVS74P3Q3NBTW5VXDBANCNFSM6AAAAAAVGX24NM . You are receiving this because you were mentioned.Message ID: @.***>

nielslange commented 1 year ago

Thanks, Moss! 🙌