search

woocommerce / woocommerce-e2e-boilerplate

GNU General Public License v3.0
18 stars 3 forks source link

Where is package.json ? #6

Closed colmtroy closed 3 years ago

colmtroy commented 3 years ago

Howdy!

Looking at using this boilerplate for testing a new plugin I'm working on. I note in the readme the following:

Modify package.json and add the following under scripts.

I don't see the a package.json in the repo - am I right to assume the readme assumes one already has a package.json in place for their plugin or is there a file missing?

Thanks!

lsinger commented 3 years ago

Thanks for the note, @colmtroy! That's correct, we assume an existing extension with an existing package.json.

To resolve this issue, we should probably make this clearer in the README.

As a second step, it would be nice if we could provide a very basic barebones extension that one could then use to explore the e2e boilerplate.

lsinger commented 3 years ago

Just added the note in 5585f30.

BrianHenryIE commented 3 years ago

I think it would be good to mention npm init in the documentation:

If your project does not contain a package.json, create one using npm init.

rrennick commented 3 years ago

@BrianHenryIE Thanks, good suggestion.

zhongruige commented 3 years ago

Closed with https://github.com/woocommerce/woocommerce-e2e-boilerplate/pull/13