search

woocommerce / woocommerce-gateway-stripe

The official Stripe Payment Gateway for WooCommerce
https://wordpress.org/plugins/woocommerce-gateway-stripe/
231 stars 203 forks source link

[ECE] Fix empty space for express checkout container #3470

Open Mayisha opened 6 days ago

Mayisha commented 6 days ago

Issue 1

Discovered in https://github.com/woocommerce/woocommerce-gateway-stripe/pull/3439#issuecomment-2356695099

When Apple Pay is not supported in the browser, there is still a space for the Apple Pay container in the block checkout.

370430718-8f0068b3-594c-4cef-8d67-61803f3ebc3a

Issue 2

Discovered in https://github.com/woocommerce/woocommerce-gateway-stripe/pull/3439#issuecomment-2374680672

When Google/Apple Pay is disabled in the Stripe settings page and ECE feature flag is true, an empty express checkout section is loaded.

Checkout page Cart Page
checkout cart

Issue 3

Add many or expensive products to your cart so that the cart total is beyond $1,000,000.00 USD (or 1.000.000,00 EUR). Notice that an empty express checkout section is loaded.

Checkout page Cart Page
checkout cart

Issue 4

Empty express checkout section is displayed in the localhost.

Checkout page Cart Page
checkout cart

Expected behavior

If the ECE button is not supported in the browser, do not occupy space for the button in the express checkout button section.

Mayisha commented 1 day ago

Issue 1 => fixed in https://github.com/woocommerce/woocommerce-gateway-stripe/pull/3439

Issues 2,3,4 => fixed in https://github.com/woocommerce/woocommerce-gateway-stripe/pull/3484