Closed annemirasol closed 1 month ago
When taxes are based on shipping address but the cart/product is virtual, taxes get based on billing address -- something we will not have access to until the payment sheet is submitted.
Adding this note here as I was revisiting ECE and taxes and wondered why have included logic for virtual products with shipping-based tax setup.
Part of #3472
Changes proposed in this Pull Request:
When the cart contains a virtual product and taxes are computed based on customer shipping or billing address, we are unable to display the correct tax computation in the ECE modal. This is because the address attached to the ECE card is not available to us until the payment is submitted.
For these cases, instead of presenting a possibly incorrect total to the customer, we are opting to hide ECE instead, similar to the WooPayments approach.
Testing instructions
_wcstripe_feature_ece
with a value ofyes
towp_options
Apple Pay/Google Pay
is enabled as payment methods.Enable tax rates and calculations
in WooCommerce > Settings > General.No, I will enter prices exclusive of tax
Customer shipping address
orCustomer billing address
Shop base address
.changelog.txt
andreadme.txt
(or does not apply)Post merge