woocommerce / woocommerce-gateway-stripe

The official Stripe Payment Gateway for WooCommerce
https://wordpress.org/plugins/woocommerce-gateway-stripe/
236 stars 206 forks source link

Remove duplicate banner #3562

Closed Mayisha closed 3 days ago

Mayisha commented 3 weeks ago

Fixes #3561

When the legacy checkout is enabled, 2 different banners are displayed with a similar message.

Changes proposed in this Pull Request:

Showing 'LegacyExperienceTransitionNotice' only when the promotional banner is not about the same.

Testing instructions

Screenshot 2024-10-30 at 6 01 05 PM Screenshot 2024-10-30 at 6 00 39 PM
aheckler commented 3 weeks ago

Does this affect only the Payment Methods tab, or both Payment Methods and Settings tabs?

Mayisha commented 3 weeks ago

Does this affect only the Payment Methods tab, or both Payment Methods and Settings tabs?

@aheckler only the payment methods tab.

wjrosa commented 3 weeks ago

Thanks for this fix, @Mayisha ! I am getting the following error when I enable the legacy checkout: Screenshot 2024-10-31 at 09 02 53 It seems the error happens with promotional-banner-section.js

Mayisha commented 2 weeks ago

Hi @wjrosa 👋

I am getting the following error when I enable the legacy checkout:

I can not reproduce this issue. However, I was getting some other console errors/warnings which I fixed in e5a72d0. 👀