woocommerce / woocommerce-gateway-stripe

The official Stripe Payment Gateway for WooCommerce
https://wordpress.org/plugins/woocommerce-gateway-stripe/
229 stars 200 forks source link

Implement bancontact[preferred_language] parameter for Bancontact Source #482

Closed Luminus closed 6 years ago

Luminus commented 6 years ago

Affected ticket(s)

914752-zen

What I expected

User expected their Bancontact authorization page to be in Dutch based on their locale

What happened instead

Bancontact authorization page is in French Screenshot Full Size: https://i.imgur.com/ALC4lUh.jpg

Steps to implement

Per the response from Stripe, implementing the bancontact[preferred_language] parameter will allow users to select one of the available preferred languages for the Bancontact authorization page that the customer is redirected to which are: en, de, fr, and nl as outlined here - https://stripe.com/docs/sources/bancontact


Luminus commented 6 years ago

@roykho you superhero. Thanks for jumping on this super quick.

I see there's a get_locale() call so I assume this will pull the locale that they've set for the site.

Are we going to add a form element to the Sofort and Bancontact settings pages like we have on the Stripe settings page so that users can select their preferred language or will we just leave it like this?

I've got a screenshot below in case I'm not making sense locale

roykho commented 6 years ago

@Luminus we will not add a setting for that. In fact the setting you're showing should have been removed as well. Going forward what is set for the store as the language will be the locale for all of these. Wouldn't it be super weird if your store is in English, then you open up a Stripe dialog and it is in Spanish :)