woocommerce / woocommerce-google-analytics-integration

WordPress plugin: Provides the integration between WooCommerce and Google Analytics.
http://wordpress.org/plugins/woocommerce-google-analytics-integration/
170 stars 69 forks source link

QIT workflow failed at the last step which it tried to parse results and populate GHA outputs #415

Closed ianlin closed 5 months ago

ianlin commented 5 months ago

Describe the bug:

Same as the issue woocommerce/google-listings-and-ads#2355

While I was doing WC 8.8 compatibility test and found the QIT workflow failed at the last step which it tried to parse results and populate GHA outputs.

The QIT test itself was successful, as we can see it in QIT results dashboard

Steps to reproduce:

  1. Run a new QIT workflow, or just refer to this one that was already ran.
  2. You should see Run QIT Tests activation (4582252): success - No errors detected.
  3. You should also see Run QIT Tests The template is not valid. woocommerce/grow/actions-v1/run-qit-annotate/action.yml (Line: 79, Col: 12): Error reading JToken from JsonReader. Path '', line 0, position 0.

Expected behavior:

The last step of QIT workflow should passed without any error.

Actual behavior:

The last step of QIT workflow was failed when parsing results and populates GHA outputs.

Additional details:

tomalec commented 5 months ago

The thing is, the QIT security test does not take woocommerce_version option:

The "--woocommerce_version" option does not exist.  

See https://github.com/woocommerce/qit-cli/issues/136.

So, I think it's more of a matter of specifying the option caveat in the compact testing checklist.

ianlin commented 5 months ago

The thing is, the QIT security test does not take woocommerce_version option:

The "--woocommerce_version" option does not exist.

Ah you're right, thanks for clarifying. I'm closing this issue as this is more of an options selection guide. The options of running QIT for WC compatibility should be like:

Screenshot 2024-04-10 at 12 12 11