woocommerce / woocommerce-google-analytics-integration

WordPress plugin: Provides the integration between WooCommerce and Google Analytics.
http://wordpress.org/plugins/woocommerce-google-analytics-integration/
172 stars 69 forks source link

Avoid running malicious inputs as shell commands in the GitHub Actions #420

Closed eason9487 closed 5 months ago

eason9487 commented 5 months ago

Changes proposed in this Pull Request:

This PR avoids running malicious inputs as shell commands in the GitHub Actions.

Although these input values are entered by devs who have access to this repo, which means it's almost unlikely to be vulnerable to such attacks, it would be better to fix it.

Checks:

Detailed test instructions:

  1. Please refer to the PR https://github.com/woocommerce/google-listings-and-ads/pull/2397 that fixes the same issue.
  2. Check if the "Install WP release candidate" and "Install WC release candidate" steps can work as before when entering valid versions
  3. Check if the "Install WP tests" step can work as before when entering valid versions

Changelog entry