Avoid changing dashboard cards multiple times

selanthiraiyan commented 2 weeks ago

Closes: #12610

Description

I suspect that it could be related to this code. Let me know your thoughts.

My hypothesis,

Reason for crash

We set up the dashboardCards value from an await call.
The view will try to render itself once the dashboardCards value is set.
Right after the dashboardCards value is set, we try to remove values from dashboardCards array. This removal for some reason happens when the view is going through dashboardCards in a for loop to render itself. (Note that the method updateDashboardCards is actually async.)

Possible solution What if we refactor the code to write to dashboardCards and unavailableDashboardCards only once from the updateDashboardCards method? We can push this onto a branch and ask Paolo to reproduce the crash.

Testing instructions

Screenshots

[ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

dangermattic commented 2 weeks ago

	1 Message
:book:	This PR is still a Draft: some checks will be skipped.

Generated by :no_entry_sign: Danger

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS
	Build Number	pr12611-583284e
	Version	18.4
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	583284ea9412191b67f9fd8bfe9691bb9eea22c8
	App Center Build	WooCommerce - Prototype Builds #8897

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

selanthiraiyan commented 2 weeks ago

Closing this PR as this didn't fix the issue. I raised another PR with a fix. https://github.com/woocommerce/woocommerce-ios/pull/12616

woocommerce / woocommerce-ios