woocommerce / woocommerce-ios

WooCommerce iOS app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
257 stars 108 forks source link

Fix: Inconsistent Padding Issues in `DashboardCardErrorView` Across Multiple Views #12615

Closed pmusolino closed 2 weeks ago

pmusolino commented 2 weeks ago

Description

This PR resolves an issue where DashboardCardErrorView was displaying inconsistent padding across different views when tested under specific network conditions. The problem was particularly noticeable when the "Network Link Conditioner" was enabled with the "100% Loss" profile, simulating a complete network loss scenario. In some views, there was an absence of padding, while in others, padding was only present on the leading side. This inconsistency affected the following views of the Dashboard:

Steps to Reproduce

  1. Enable "Network Link Conditioner" on your testing device or simulator.
  2. Set the profile to "100% Loss" to simulate a complete network disconnect.
  3. Navigate to the views mentioned above and observe the padding inconsistency in the cards of the Dashboard.

Screenshots

Before After
Simulator Screenshot - iPhone 15 Pro - 2024-04-30 at 11 06 00 Simulator Screenshot - iPhone 15 Pro - 2024-04-30 at 12 03 01
wpmobilebot commented 2 weeks ago

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr12615-e953e14
Version18.4
Bundle IDcom.automattic.alpha.woocommerce
Commite953e14e0f8526e99f44f79eac35a302fb793e34
App Center BuildWooCommerce - Prototype Builds #8902

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.