Closed rachelmcr closed 2 weeks ago
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
App Name | WooCommerce iOS | |
Build Number | pr12621-9bb74ec | |
Version | 18.4 | |
Bundle ID | com.automattic.alpha.woocommerce | |
Commit | 9bb74ec4272fc000d0b3b1097f2a841037cfb19a | |
App Center Build | WooCommerce - Prototype Builds #8911 |
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
2 Warnings | |
---|---|
:warning: | This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews. |
:warning: | This PR is assigned to the milestone 18.5. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline. |
Generated by :no_entry_sign: Danger
@woocommerce/mobile-ui-testing-squad I'm going to go ahead and merge these changes. Please let me know if you have any concerns about the UI test changes (https://github.com/woocommerce/woocommerce-ios/pull/12621/commits/ccbfabe994977dabc16906db739994a5ecc3b0dd) and I can address them in a followup PR.
Part of: #12578
Why
This updates the styles on the Add/Edit Shipping screen in the order form, when the
enhancingOrderShippingLines
feature flag is enabled.How
ShippingLineSelectionDetails
view and view model. I decided to use a new view because the style changes also meant some significant changes in the view's logic and data handling. This will make it easier to remove the old view when we release these changes.ShippingLineDetailsViewModel
to test the same functionality inShippingLineSelectionDetailsViewModel
.EditableOrderViewModel
.OrderForm
to navigate to the new view when the feature flag is enabled.FormattableAmountTextField
for editing the shipping amount. I updated that view and its view model:Testing instructions
Screenshots
RELEASE-NOTES.txt
if necessary.