woocommerce / woocommerce-ios

WooCommerce iOS app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
257 stars 108 forks source link

[Shipping Lines] Update styles on Shipping screen in order form #12621

Closed rachelmcr closed 2 weeks ago

rachelmcr commented 2 weeks ago

Part of: #12578

Why

This updates the styles on the Add/Edit Shipping screen in the order form, when the enhancingOrderShippingLines feature flag is enabled.

How

Testing instructions

  1. Build and run the app.
  2. Create a new order.
  3. Add a product to the order.
  4. Tap the "Add Shipping" button to open the shipping details screen.
  5. Confirm you can add a shipping amount (positive or negative) and name.
  6. Add the shipping to the order.
  7. In the order total section, select the shipping row to edit it.
  8. Confirm you can edit the shipping amount and name.
  9. Confirm you can remove the shipping from the order.

Screenshots

Existing styles (feature flag disabled) New styles (feature flag enabled)
Simulator Screenshot - iPhone 15 Pro - 2024-04-30 at 17 31 52 Simulator Screenshot - iPhone 15 Pro - 2024-04-30 at 17 40 58
Simulator Screenshot - iPhone 15 Pro - 2024-04-30 at 17 31 57 Simulator Screenshot - iPhone 15 Pro - 2024-04-30 at 17 41 12
Simulator Screenshot - iPhone 15 Pro - 2024-04-30 at 17 32 14 Simulator Screenshot - iPhone 15 Pro - 2024-04-30 at 17 29 22

wpmobilebot commented 2 weeks ago

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr12621-9bb74ec
Version18.4
Bundle IDcom.automattic.alpha.woocommerce
Commit9bb74ec4272fc000d0b3b1097f2a841037cfb19a
App Center BuildWooCommerce - Prototype Builds #8911

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

dangermattic commented 2 weeks ago
2 Warnings
:warning: This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
:warning: This PR is assigned to the milestone 18.5. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

rachelmcr commented 2 weeks ago

@woocommerce/mobile-ui-testing-squad I'm going to go ahead and merge these changes. Please let me know if you have any concerns about the UI test changes (https://github.com/woocommerce/woocommerce-ios/pull/12621/commits/ccbfabe994977dabc16906db739994a5ecc3b0dd) and I can address them in a followup PR.