woocommerce / woocommerce-ios

WooCommerce iOS app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
257 stars 108 forks source link

[Dynamic Dashboard] In-app feedback card #12636

Closed selanthiraiyan closed 1 week ago

selanthiraiyan commented 2 weeks ago

Closes: #12600

Description

Show the in-app feedback card on the SwiftUI-based dashboard screen.

Changes

Testing instructions

Survey flow

Rating flow

Screenshots

Dark Light
IMG_80BC3E7E98C5-1 IMG_BE43BE952EC3-1

Survey flow https://github.com/woocommerce/woocommerce-ios/assets/524475/0f0cd4a4-1b22-4347-b473-d17d2cc29ded

Rating flow

https://github.com/woocommerce/woocommerce-ios/assets/524475/992305ab-4aa9-4be3-b2d0-ec8836e2f237


wpmobilebot commented 2 weeks ago

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr12636-5814f40
Version18.5
Bundle IDcom.automattic.alpha.woocommerce
Commit5814f400f940de2d00a1a312640e23c15b55574c
App Center BuildWooCommerce - Prototype Builds #8957

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

hafizrahman commented 2 weeks ago

I can't make the rating view appear, so could use your direction to check what I'm missing.

Here's my steps:

  1. Delete app on real device,
  2. Build app on real device,
  3. Login,
  4. First thing I see is the Feature Announcement,
  5. Go to Date & Setting, change device date to December 2024,
  6. Go back to app, close Feature Announcement, refresh My Store,
  7. In-App feedback card is shown,
  8. Tap "Could be better" (trackings are shown correctly)
  9. Survey screen shown,
  10. Close survey screen, In-app feedback card is hidden,
  11. Go back to Xcode, update .sendIsInAppFeedbackCardVisibleValueAndTrackIfNeeded(true)
  12. Build app again,
  13. My Store now shows in-app feedback card again,
  14. Tap "Could be better",
  15. Survey screen is shown again, instead of the rating view.
itsmeichigo commented 1 week ago

Just chiming in: I believe we should remove InAppFeedbackCardViewController and the related xib file too as they are no longer used.

dangermattic commented 1 week ago
1 Warning
:warning: This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by :no_entry_sign: Danger

selanthiraiyan commented 1 week ago

Thanks for the review, @hafizrahman!

Before testing the app rating flow, the app needs to be deleted and installed again. I'm sorry; I updated the test instructions now.

Kindly take another look at the PR when you can.

selanthiraiyan commented 1 week ago

Thanks @itsmeichigo! Good point.

Just chiming in: I believe we should remove InAppFeedbackCardViewController and the related xib file too as they are no longer used.

Done in https://github.com/woocommerce/woocommerce-ios/pull/12636/commits/a2fdb4fb64b8c3d1a5717a27ff49b64803662c52

selanthiraiyan commented 1 week ago

Thanks for the review, @hafizrahman! I sneaked in a commit which fixes something that I missed while resolving merge conflicts. https://github.com/woocommerce/woocommerce-ios/pull/12636/commits/5814f400f940de2d00a1a312640e23c15b55574c Enabling auto-merge now. 🙇