Closed selanthiraiyan closed 1 week ago
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
App Name | WooCommerce iOS | |
Build Number | pr12636-5814f40 | |
Version | 18.5 | |
Bundle ID | com.automattic.alpha.woocommerce | |
Commit | 5814f400f940de2d00a1a312640e23c15b55574c | |
App Center Build | WooCommerce - Prototype Builds #8957 |
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
I can't make the rating view appear, so could use your direction to check what I'm missing.
Here's my steps:
.sendIsInAppFeedbackCardVisibleValueAndTrackIfNeeded(true)
Just chiming in: I believe we should remove InAppFeedbackCardViewController
and the related xib file too as they are no longer used.
1 Warning | |
---|---|
:warning: | This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews. |
Generated by :no_entry_sign: Danger
Thanks for the review, @hafizrahman!
Before testing the app rating flow, the app needs to be deleted and installed again. I'm sorry; I updated the test instructions now.
Kindly take another look at the PR when you can.
Thanks @itsmeichigo! Good point.
Just chiming in: I believe we should remove InAppFeedbackCardViewController and the related xib file too as they are no longer used.
Thanks for the review, @hafizrahman! I sneaked in a commit which fixes something that I missed while resolving merge conflicts. https://github.com/woocommerce/woocommerce-ios/pull/12636/commits/5814f400f940de2d00a1a312640e23c15b55574c Enabling auto-merge now. 🙇
Closes: #12600
Description
Show the in-app feedback card on the SwiftUI-based dashboard screen.
Changes
DashboardViewModel
.DashboardView
Testing instructions
Survey flow
Rating flow
shouldBeVisible
intotrue
in this line https://github.com/woocommerce/woocommerce-ios/pull/12636/files#diff-5e4b4001de415046921cf84e4ce2b6c16646ae1bb2067aa6d9ec1fbfa2a855e5R413 to always show the in-app feedback card. Code change is required as changing Date disrupts the App store rating part due to certificate expired error.Screenshots
Survey flow https://github.com/woocommerce/woocommerce-ios/assets/524475/0f0cd4a4-1b22-4347-b473-d17d2cc29ded
Rating flow
https://github.com/woocommerce/woocommerce-ios/assets/524475/992305ab-4aa9-4be3-b2d0-ec8836e2f237
RELEASE-NOTES.txt
if necessary.