Dynamic Dashboard: Coupons Card UI

selanthiraiyan commented 2 weeks ago

Part of: #12716

Description

Adds a first iteration of UI related code for the "Most Active Coupons" dashboard card.

Changes

View and View model for "Most Active Coupons" dashboard card.
Way to store and retrieve selected time range to App settings.
Open the coupons list screen.
Update coupon summary text format to match new design.

Testing instructions

Enable the feature flag dynamicDashboardM2 and build the app.
Confirm that the dashboard still has the same layout as before.
Tap Edit button and confirm that there's an option for the most active coupons card and it's disabled.
Enable coupons card and save the change.
Confirm that the coupons card is displayed on the dashboard.
Confirm that the UI matches the Figma design.
Tap View all coupons, confirm that coupons list screen is displayed.
Tap the calendar icon and change time range, validate that time range selection works.
- "All time" time range is removed as we don't have option to fetch that time range from API.
Tap the ellipsis menu on the coupons card, confirm that there's an option Hide Coupons.
Tap Hide coupons, confirm that the customize screen is displayed.

Disable the dynamicDashboardM2 flag and confirm that the Coupons card is not available.

Screenshots

Light	Dark

[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS
	Build Number	pr12733-69fd824
	Version	18.6
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	69fd824d93711d44e247d6f31ae50098c17cdfe9
	App Center Build	WooCommerce - Prototype Builds #9072

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

dangermattic commented 2 weeks ago

	2 Warnings
:warning:	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
:warning:	This PR is assigned to the milestone 18.7. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

selanthiraiyan commented 2 weeks ago

Thanks for the review, @itsmeichigo!

Also, I tried editing the coupon from the ellipsis menu of the coupon details screen but the edit screen could not be displayed. Can you double-check that please?

I started presenting the coupon detail from DashboardViewHostingController to fix this.

I have addressed your other comments as well. This PR is ready for another round of review. 🙏

woocommerce / woocommerce-ios